Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PHP 8.3 Compatibility #7678

Merged
merged 7 commits into from
Nov 28, 2023
Merged

Improve PHP 8.3 Compatibility #7678

merged 7 commits into from
Nov 28, 2023

Conversation

swissspidy
Copy link
Collaborator

@swissspidy swissspidy commented Nov 24, 2023 •
edited by thelovekesh

Summary

See also

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@swissspidy swissspidy added the Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs label Nov 24, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 24, 2023 •
edited

Plugin builds for f138b04 are ready 🛎️!

Checksums 
# Development build checksums
fbabaad5ea677436b021a0a7304f736566768726ff990c623a9407967ae76749 *amp.zip

# Production build checksums
90f86d7a6a02df01b83d15bea7e5790fe6c69622f0c1667838e82bd4c37e7df9 *amp.zip

Warning

These builds are for testing purposes only and should not be used in production.

@swissspidy
Copy link
Collaborator Author

All PHP warnings seem to have been gone.

The failing tests are unrelated I think, as WP 6.4 happened in the meantime.

@westonruter westonruter added this to the v2.5.1 milestone Nov 27, 2023
@westonruter
Copy link
Member

Looks like Test_AMP_Validation_Manager::test_add_block_source_comments is failing due to an update in Gutenberg.

swissspidy and others added 2 commits November 28, 2023 09:12
@thelovekesh
Copy link
Collaborator

thelovekesh commented Nov 28, 2023 •
edited

Tests were failing due to changes introduced by WordPress/wordpress-develop@ac8bca4fdf in core and by WordPress/gutenberg#55240 in GB plugin 17.1.0+.

westonruter
westonruter approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both!

@westonruter westonruter merged commit 4f16c6b into develop Nov 28, 2023
36 of 37 checks passed
@westonruter westonruter deleted the add/php83 branch November 28, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

Assignees

@thelovekesh thelovekesh

Labels
Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs
Projects
None yet
Milestone
v2.5.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@swissspidy @westonruter @thelovekesh