Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Nodejs; Fix PHPStan and PHPUnit failures #7719

Merged
merged 9 commits into from
Mar 14, 2024
Merged

Bump Nodejs; Fix PHPStan and PHPUnit failures #7719

merged 9 commits into from
Mar 14, 2024

Conversation

thelovekesh
Copy link
Collaborator

@thelovekesh thelovekesh commented Jan 18, 2024 •
edited

Summary

Fixes #7717

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 18, 2024 •
edited

Plugin builds for 1a909d3 are ready 🛎️!

Checksums 
# Development build checksums
d8f82627cd13ee0930317a9b61bcaabe0fed241d21404b7fdac106f394598fa0 *amp.zip

# Production build checksums
b35325eda214405798e2b9c0b68c9c1311bc3f2c1fa45b0b866239a05a1d742f *amp.zip

Warning

These builds are for testing purposes only and should not be used in production.

@thelovekesh thelovekesh marked this pull request as draft January 18, 2024 15:38
@westonruter westonruter added this to the v2.5.3 milestone Jan 18, 2024
@westonruter
Copy link
Member

@thelovekesh how's this going?

@thelovekesh
Copy link
Collaborator Author

thelovekesh commented Feb 15, 2024 •
edited

@westonruter planning to finish this in the next few days, most probably on Tuesday.

@thelovekesh thelovekesh force-pushed the bump/node branch 2 times, most recently from 66d6a6a to cbff875 Compare March 14, 2024 08:10
This was referenced Mar 14, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@thelovekesh thelovekesh marked this pull request as ready for review March 14, 2024 14:16
@thelovekesh
Copy link
Collaborator Author

@westonruter For testing purposes I had to bump all the NPM dependencies to the latest version so I have closed dependabot PRs this time.

@thelovekesh thelovekesh changed the title Bump node from 18 to 20 Bump Nodejs; Fix PHPStan and PHPUnit failures Mar 14, 2024
@westonruter westonruter merged commit ecb3124 into develop Mar 14, 2024
39 of 63 checks passed
@westonruter westonruter deleted the bump/node branch March 14, 2024 15:48
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

Assignees
No one assigned
Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Milestone
v2.5.3
Development

Successfully merging this pull request may close these issues.

Update node to v20
2 participants
@thelovekesh @westonruter