Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added meta tag for identifying AMP pages generated by plugin #810

Merged
merged 7 commits into from Dec 5, 2017
Merged

Added meta tag for identifying AMP pages generated by plugin #810

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
25508a1
Added meta tag for identifying AMP pages generated by plugin. Issue #807
vaporwavre Nov 22, 2017
5089b23
Add a function that outputs the generated by meta tag at the amp_post…
vaporwavre Nov 23, 2017
b2271ff
Fix WPCS error (Squiz.Commenting.FunctionComment.Missing)
vaporwavre Nov 28, 2017
f400b66
Fix WPCS error (WordPress.Arrays.MultipleStatementAlignment.DoubleArr…
vaporwavre Nov 28, 2017
f6cbcb3
Fix WPCS error FuctionComment.Missing
vaporwavre Dec 5, 2017
045dc35
Fix WPCS error FuctionComment.ParamNameNoMatch
vaporwavre Dec 5, 2017
e169bc0
Code formatting
ThierryA Dec 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions includes/actions/class-amp-actions.php
View file
Open in desktop
Expand Up @@ -9,4 +9,5 @@ public static function add_schemaorg_metadata( $template ) {}
public static function add_analytics_scripts( $template ) {}
public static function add_analytics_data( $template ) {}
public static function add_canonical_link( $template ) {}
public static function add_generatedby_metadata( $template ) {}
}
7 changes: 7 additions & 0 deletions includes/actions/class-amp-paired-post-actions.php
View file
Open in desktop
Expand Up @@ -5,6 +5,7 @@
class AMP_Paired_Post_Actions extends AMP_Actions {

public static function register_hooks() {
add_action( 'amp_post_template_head', 'AMP_Paired_Post_Actions::add_generatedby_metadata' );
add_action( 'amp_post_template_head', 'AMP_Paired_Post_Actions::add_title' );
add_action( 'amp_post_template_head', 'AMP_Paired_Post_Actions::add_canonical_link' );
add_action( 'amp_post_template_head', 'AMP_Paired_Post_Actions::add_scripts' );
Expand Down Expand Up @@ -104,4 +105,10 @@ public static function add_analytics_data( $amp_template ) {
echo AMP_HTML_Utils::build_tag( 'amp-analytics', $amp_analytics_attr, $script_element );
}
}

public static function add_generatedby_metadata( $amp_template ) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix WPCS error (Squiz.Commenting.FunctionComment.Missing). Here is a draft:

/**
 * Add AMP generator metadata.
 *
 * @param object $amp_template AMP_Post_Template object.
 * @since 0.6
 */

?>
<meta name="generator" content="<?php echo esc_attr( $amp_template->get( 'generatedby_metadata' ) );?>" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix WPCS error (Squiz.PHP.EmbeddedPhp.SpacingBeforeClose).

<?php
}
}
1 change: 1 addition & 0 deletions includes/class-amp-post-template.php
View file
Open in desktop
Expand Up @@ -57,6 +57,7 @@ public function __construct( $post_id ) {
'canonical_url' => get_permalink( $post_id ),
'home_url' => home_url(),
'blog_name' => get_bloginfo( 'name' ),
'generatedby_metadata' => 'AMP Plugin v' . AMP__VERSION,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix WPCS error (WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned).


'html_tag_attributes' => array(),
'body_class' => '',
Expand Down