Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set AMP_QUERY_VAR fallback when AMP is inactive #986

Merged
merged 2 commits into from
Mar 12, 2018
Merged

Set AMP_QUERY_VAR fallback when AMP is inactive #986

merged 2 commits into from
Mar 12, 2018

Commits on Mar 10, 2018

  1. Set AMP_QUERY_VAR fallback when AMP is inactive 

    If AMP is deactivated via the `amp_is_enabled` filter, the
`AMP_QUERY_VAR` ends up undefined. This causes warnings when a helper
function like `is_amp_endpoint()` is called.

Setting a fallback value prevents this.
    @mjangda @westonruter
    mjangda authored and westonruter committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    c42dd3c View commit details
    Browse the repository at this point in the history

  2. Introduce amp_get_slug() to replace AMP_QUERY_VAR

    @westonruter
    westonruter committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    d024c4c View commit details
    Browse the repository at this point in the history