Consistently use wp_parse_url(); deprecate AMP_WP_Utils #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
requested changes
Mar 8, 2018
There was a problem hiding this comment.
Bumping to 4.8 is not required yet. This can stay at 4.7 for now. Note that the removal of AMP_WP_Utils was filed in #876. By all means we should cease calling it, but we cannot straight remove the class yet since other plugins may be calling it. The class and its methods should be marked as deprecated.
|
I removed the version bump, restored the class and marked the class and its function as deprecated. |
westonruter
changed the title
westonruter
approved these changes
Mar 19, 2018
westonruter
added a commit
that referenced
this pull request
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse_url()andAMP_WP_Utils::parse_url().Fixes #876.