New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use wp_parse_url(); deprecate AMP_WP_Utils #995

Merged
merged 9 commits into from Mar 19, 2018

Conversation

Projects
None yet
2 participants
@paulschreiber
Copy link
Contributor

paulschreiber commented Mar 8, 2018

  • Consistently use wp_parse_url() instead of a combination of parse_url() and AMP_WP_Utils::parse_url().
  • Remove AMP_WP_Utils class and tests
  • Bump required version of WordPress to 4.8

Fixes #876.

@westonruter
Copy link
Member

westonruter left a comment

Bumping to 4.8 is not required yet. This can stay at 4.7 for now. Note that the removal of AMP_WP_Utils was filed in #876. By all means we should cease calling it, but we cannot straight remove the class yet since other plugins may be calling it. The class and its methods should be marked as deprecated.

@paulschreiber paulschreiber reopened this Mar 18, 2018

@paulschreiber

This comment has been minimized.

Copy link
Contributor

paulschreiber commented Mar 18, 2018

I removed the version bump, restored the class and marked the class and its function as deprecated.

@westonruter westonruter changed the title Consistently use wp_parse_url() Consistently use wp_parse_url(); deprecate AMP_WP_Utils Mar 19, 2018

@westonruter westonruter added this to the v1.0 milestone Mar 19, 2018

@westonruter westonruter merged commit 0bd1d58 into ampproject:develop Mar 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

westonruter added a commit that referenced this pull request May 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment