Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mailgun to Tools Page #2331

Closed
elliotsmith4041 opened this issue Jun 17, 2019 · 6 comments
Closed

Add Mailgun to Tools Page #2331

elliotsmith4041 opened this issue Jun 17, 2019 · 6 comments

Comments

@elliotsmith4041
Copy link

elliotsmith4041 commented Jun 17, 2019

We would like to include Mailgun.com on the AMP dev main page.

Please provide:

mailgun.com

Short Blurb:
"Mailgun's leading API-based email delivery service allows you to send dynamic email effortlessly."

Default-Gray-Red (2)

@matthiasrohmer
Copy link
Collaborator

Thanks for reaching out! I assume you're referring to mailgun's support for AMP for email?

If so feel free to add mailgun to the list in: https://github.com/ampproject/docs/blob/future/pages/shared/data/tools.yaml

By doing this your tool will then end up on our tools page.

@elliotsmith4041
Copy link
Author

elliotsmith4041 commented Jun 18, 2019 via email

@matthiasrohmer
Copy link
Collaborator

@sebil, when you are updating the tools page can you do me a favor and also add Mailgun to the list? Thank you!

@sebil
Copy link
Collaborator

sebil commented Jun 19, 2019

I'm on it

@matthiasrohmer matthiasrohmer changed the title Client to be highlighted on AMP dev site Add Mailgun to Tools Page Jun 19, 2019
@elliotsmith4041
Copy link
Author

elliotsmith4041 commented Jun 24, 2019 via email

@sebil
Copy link
Collaborator

sebil commented Jun 28, 2019

Hi Elliot,
sorry for the late response.
Since we were on a redesign for the tools page, we planned to add mailgun together with that changes.
But now Nick already added it. After a few changes it will be merged soon.

pbakaus pushed a commit that referenced this issue Jun 28, 2019
* Added Mailgun email service to tools #2331

* Adding Mailgun to the tools page

* Adding official Mailgun logo
sebil added a commit that referenced this issue Jul 1, 2019
@sebil sebil closed this as completed Jul 1, 2019
pbakaus pushed a commit that referenced this issue Jul 1, 2019
* 💄 Make tools container wider

* 💄 Remove h2 decoration line and unitize with h1

* 💄 Move teaser tag down and increase size

* 💄 Refine type section of teaser

* 💄 Reduce border-radius of teasers

* 💄 Redesign essential teasers in dark look

* 🎨 Only hide image overlay on type contain images

* 🔥 Remove specific styling for single headline case

* 🎨 Title case all type values

* ♻️ Refactor tools-filter to be like roadmap filter

* 🔥 Remove filter bubbles overflow scrolling

* 💄 Minor styling adjustments

* 🎨 Change order of filter bubbles

* 🔥 Remove wrong class name

* 🐛 Convert type name to lowercase in classnames

* 🎨 Add format icon to tag and unitize styling with filter

* ♻️ Cleanup structure and classes

Use section instead of main tag for tools container. Correctly name template class and cleanup mistakely copied stylings.

* 💄 Move amp-logo for essential tools up

And add some fancy rounded corner stylings

* 🎨 Reset teaser structure on mobile

Image is above the content. No two images needed anymore

* 🍱 Add new logo icon with transparent bolt

* 🎨 Use svg shape instead of css gradient for logo bg

* 🎨 Show image overlay also on type contain images

but with lower opacity

* ✨ Add tools-visual with dummy assets

* 👌 Adjust tools visual animation

* 👌 Adjust hover state for tools filter bubbles

* 👌 Change color of inactive tools filter bubbles

* 👌 Increase gap of tools teaser grid

* 👌 Increase size of tools teaser logo

* 👌 Adjust box-shadow of tools teasers

* 👌 Make tags inside tools teaser filterable

Move them outside of clickable <a> element and simulate hover effect via parent and sibling selectors

* ♿ Disable animations on reduce motion

* 👌 Add description to email services tools

* 🍱 Add missing tools images

* 👌 Implement new tools images

* 💬 Title case type name of tool

* 👌 Adjust box-shadows

* 🐛 Add role and tabindex due to amp validation errors

* 👌 Finalize tools-page

* 💬 Add description to mailgun tool

#2331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants