Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to import CORS guide #531

Merged
4 commits merged into from May 31, 2017
Merged

Add functionality to import CORS guide #531

4 commits merged into from May 31, 2017

Conversation

ghost
Copy link

@ghost ghost commented May 30, 2017

Per #478, include the CORS guide from the AMPHTML repo into the ampproject.org docset.

Don't merge this PR until updates for AMP CORS guide is merged (ampproject/amphtml#9607)

@ghost ghost requested a review from pbakaus May 30, 2017 13:32
@@ -32,6 +32,7 @@ gulp.task('import-docs', function (cb) {
if (err instanceof Error) {
cb(err);
}
//console.log(stdout);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover? :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I purposely kept it commented out because I'm always forgetting how to turn it on. I thought it no harm to leave it in, but commented.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, all good then!

@ghost ghost self-assigned this May 30, 2017
@ghost ghost merged commit f08239d into master May 31, 2017
@ghost ghost deleted the docs-import-CORS-guide branch May 31, 2017 18:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant