-
Notifications
You must be signed in to change notification settings - Fork 3.9k
/
test-amp-story-auto-ads.js
467 lines (420 loc) · 14.9 KB
/
test-amp-story-auto-ads.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
import {CommonSignals_Enum} from '#core/constants/common-signals';
import * as experiments from '#experiments';
import {forceExperimentBranch, getExperimentBranch} from '#experiments';
import {Services} from '#service';
import {macroTask} from '#testing/helpers';
import {
MockStoryImpl,
addStoryAutoAdsConfig,
addStoryPages,
} from './story-mock';
import {registerServiceBuilder} from '../../../../src/service-helpers';
import {AmpStory} from '../../../amp-story/1.0/amp-story';
import {NavigationDirection} from '../../../amp-story/1.0/amp-story-page';
import {
Action,
StateProperty,
UIType,
getStoreService,
} from '../../../amp-story/1.0/amp-story-store-service';
import * as storyEvents from '../../../amp-story/1.0/events';
import {
AmpStoryAutoAds,
Attributes,
RELEVANT_PLAYER_EXPS,
} from '../amp-story-auto-ads';
import {StoryAdPage} from '../story-ad-page';
forceExperimentBranch;
const NOOP = () => {};
// TODO(ccordry): Refactor these tests using new associated classes & try to remove stubbing private methods.
describes.realWin(
'amp-story-auto-ads',
{
amp: {
extensions: ['amp-story:1.0', 'amp-story-auto-ads'],
},
},
(env) => {
let win;
let doc;
let adElement;
let storyElement;
let autoAds;
let story;
let storeService;
let storeGetterStub;
let viewer;
beforeEach(() => {
win = env.win;
doc = win.document;
viewer = Services.viewerForDoc(env.ampdoc);
env.sandbox.stub(Services, 'viewerForDoc').returns(viewer);
registerServiceBuilder(win, 'performance', function () {
return {
isPerformanceTrackingOn: () => false,
};
});
adElement = win.document.createElement('amp-story-auto-ads');
storyElement = win.document.createElement('amp-story');
win.document.body.appendChild(storyElement);
storyElement.appendChild(adElement);
story = new AmpStory(storyElement);
autoAds = new AmpStoryAutoAds(adElement);
storeService = getStoreService(win);
storeGetterStub = env.sandbox.stub(storeService, 'get');
// Tests by default assume an 8 page parent story. Overide if needed.
storeGetterStub
.withArgs(StateProperty.PAGE_IDS)
.returns(['1', '2', '3', '4', '5', '6', '7', '8']);
storeGetterStub.callThrough();
});
describe('shared experiments', () => {
beforeEach(async () => {
RELEVANT_PLAYER_EXPS[123] = 'fake-exp';
env.sandbox.stub(viewer, 'isEmbedded').returns(true);
new MockStoryImpl(storyElement);
addStoryAutoAdsConfig(adElement);
});
it('handles null response', async () => {
const forceExpStub = env.sandbox.stub(
experiments,
'forceExperimentBranch'
);
env.sandbox
.stub(viewer, 'sendMessageAwaitResponse')
.returns(Promise.resolve(null));
await autoAds.buildCallback();
expect(forceExpStub).not.to.be.called;
});
it('handles empty array', async () => {
const forceExpStub = env.sandbox.stub(
experiments,
'forceExperimentBranch'
);
env.sandbox
.stub(viewer, 'sendMessageAwaitResponse')
.returns(Promise.resolve({experimentIds: []}));
await autoAds.buildCallback();
expect(forceExpStub).not.to.be.called;
});
it('correctly ssets relevant ids', async () => {
env.sandbox
.stub(viewer, 'sendMessageAwaitResponse')
.returns(Promise.resolve({experimentIds: [123]}));
await autoAds.buildCallback();
expect(getExperimentBranch(win, 'fake-exp')).to.equal('123');
});
it('does not set random ids', async () => {
const forceExpStub = env.sandbox.stub(
experiments,
'forceExperimentBranch'
);
env.sandbox
.stub(viewer, 'sendMessageAwaitResponse')
.returns(Promise.resolve({experimentIds: [456]}));
await autoAds.buildCallback();
expect(forceExpStub).not.to.be.called;
});
});
describe('ad creation', () => {
beforeEach(() => {
new MockStoryImpl(storyElement);
addStoryAutoAdsConfig(adElement);
});
it('creates an ad when story pages > min interval', async () => {
await autoAds.buildCallback();
await autoAds.layoutCallback();
const ampAd = doc.querySelector('amp-ad');
expect(ampAd).to.exist;
});
it('doesnt create ad when story pages < min interval', async () => {
storeGetterStub
.withArgs(StateProperty.PAGE_IDS)
.returns(['1', '2', '3', '4']);
await autoAds.buildCallback();
await autoAds.layoutCallback();
const ampAd = doc.querySelector('amp-ad');
expect(ampAd).not.to.exist;
});
it('does not create multiple ads in stories of 8 pages', async () => {
await autoAds.buildCallback();
await autoAds.layoutCallback();
// Fake click to ad page.
storeService.dispatch(Action.CHANGE_PAGE, {
id: 'i-amphtml-ad-page-1',
index: 7,
});
const ampAds = doc.querySelectorAll('amp-ad');
expect(ampAds.length).to.equal(1);
});
it('creates multiple ads if enough pages', async () => {
storeGetterStub
.withArgs(StateProperty.PAGE_IDS)
.returns([
'1',
'2',
'3',
'4',
'5',
'6',
'7',
'8',
'9',
'10',
'11',
'12',
'13',
'14',
'15',
]);
await autoAds.buildCallback();
await autoAds.layoutCallback();
// Fake click to ad page.
storeService.dispatch(Action.CHANGE_PAGE, {
id: 'i-amphtml-ad-page-1',
index: 7,
});
const ampAds = doc.querySelectorAll('amp-ad');
expect(ampAds.length).to.equal(2);
});
it('does not fetch new ad when viewing previous ad', async () => {
await autoAds.buildCallback();
await autoAds.layoutCallback();
// Fake click to ad page.
storeService.dispatch(Action.CHANGE_PAGE, {
id: 'i-amphtml-ad-page-1',
index: 7,
});
// Visit ad page again.
storeService.dispatch(Action.CHANGE_PAGE, {
id: 'i-amphtml-ad-page-1',
index: 7,
});
const ampAds = doc.querySelectorAll('amp-ad');
expect(ampAds.length).to.equal(1);
});
});
describe('service installation', () => {
let installExtensionForDocStub;
beforeEach(() => {
installExtensionForDocStub = env.sandbox.spy();
env.sandbox
.stub(Services.extensionsFor(win), 'installExtensionForDoc')
.callsFake(installExtensionForDocStub);
new MockStoryImpl(storyElement);
});
it('should install amp-mustache when type="custom"', async () => {
const config = {
type: 'custom',
'data-url': '/some/fake/path',
};
addStoryAutoAdsConfig(adElement, config);
await autoAds.buildCallback();
await autoAds.layoutCallback();
expect(installExtensionForDocStub).to.be.calledWithExactly(
env.ampdoc,
'amp-mustache',
'latest'
);
});
it('should not install amp-mustache when type!="custom"', async () => {
const config = {
type: 'doubleclick',
'data-slot': '/300200/foo',
};
new MockStoryImpl(storyElement);
addStoryAutoAdsConfig(adElement, config);
await autoAds.buildCallback();
await autoAds.layoutCallback();
expect(installExtensionForDocStub).not.to.be.calledWithExactly(
env.ampdoc,
'amp-mustache'
);
});
});
describe('glass pane', () => {
beforeEach(async () => {
new MockStoryImpl(storyElement);
addStoryAutoAdsConfig(adElement);
await autoAds.buildCallback();
await autoAds.layoutCallback();
});
it('should create glassPane', () => {
const pane = doc.querySelector('.i-amphtml-glass-pane');
expect(pane).to.exist;
});
it('glass pane should have full viewport grid parent', () => {
const pane = doc.querySelector('.i-amphtml-glass-pane');
const parent = pane.parentElement;
expect(parent.tagName).to.equal('AMP-STORY-GRID-LAYER');
expect(parent.getAttribute('template')).to.equal('fill');
});
});
describe('visible attribute', () => {
beforeEach(() => {
new MockStoryImpl(storyElement);
addStoryAutoAdsConfig(adElement);
});
it('sets the visible attribute when showing', async () => {
const setVisibleStub = env.sandbox.stub(
autoAds,
'setVisibleAttribute_'
);
await autoAds.buildCallback();
await autoAds.layoutCallback();
// Switching to ad page.
storeService.dispatch(Action.CHANGE_PAGE, {
id: 'i-amphtml-ad-page-1',
index: 7,
});
expect(setVisibleStub.calledOnce).to.be.true;
});
it('removes the visible attribute when exiting', async () => {
const removeVisibleStub = env.sandbox.stub(
autoAds,
'removeVisibleAttribute_'
);
await autoAds.buildCallback();
await autoAds.layoutCallback();
autoAds.visibleAdPage_ = {getId: () => 'i-amphtml-ad-page-1'};
autoAds.handleActivePageChange_(
/* pageIndex */ 2,
/* pageId */ 'non-ad-page'
);
expect(removeVisibleStub.calledOnce).to.be.true;
});
});
describe('system layer', () => {
beforeEach(async () => {
// TODO(#33969) remove when launched.
// Force sync mutateElement.
env.sandbox.stub(autoAds, 'mutateElement').callsArg(0);
addStoryAutoAdsConfig(adElement);
await story.buildCallback();
// Fire these events so that story ads thinks the parent story is ready.
story.signals().signal(CommonSignals_Enum.BUILT);
story.signals().signal(CommonSignals_Enum.INI_LOAD);
await autoAds.buildCallback();
await autoAds.layoutCallback();
});
it('should create ad badge', () => {
const adBadge = doc.querySelector('.i-amphtml-story-ad-badge');
expect(adBadge).to.exist;
});
it('should propagate the ad-showing attribute to badge', () => {
const adBadgeContainer = doc.querySelector(
'.i-amphtml-ad-overlay-container'
);
expect(adBadgeContainer).not.to.have.attribute(Attributes.AD_SHOWING);
storeService.dispatch(Action.TOGGLE_AD, true);
expect(adBadgeContainer).to.have.attribute(Attributes.AD_SHOWING);
});
it('should propagate the desktop-one-panel attribute to ad badge', () => {
const adBadgeContainer = doc.querySelector(
'.i-amphtml-ad-overlay-container'
);
storeService.dispatch(Action.TOGGLE_UI, UIType.MOBILE);
expect(adBadgeContainer).not.to.have.attribute(
Attributes.DESKTOP_ONE_PANEL
);
storeService.dispatch(Action.TOGGLE_UI, UIType.DESKTOP_ONE_PANEL);
expect(adBadgeContainer).to.have.attribute(
Attributes.DESKTOP_ONE_PANEL
);
});
it('should propagate the dir=rtl attribute', () => {
const adBadgeContainer = doc.querySelector(
'.i-amphtml-ad-overlay-container'
);
expect(adBadgeContainer).not.to.have.attribute(Attributes.DIR);
storeService.dispatch(Action.TOGGLE_RTL, true);
expect(adBadgeContainer).to.have.attribute(Attributes.DIR, 'rtl');
});
});
describe('analytics triggers', () => {
it('should fire "story-ad-view" upon ad visible', () => {
autoAds.ampStory_ = {
element: storyElement,
addPage: NOOP,
};
autoAds.setVisibleAttribute_ = NOOP;
autoAds.placementAlgorithm_ = {onPageChange: NOOP};
autoAds.adPageManager_ = {
getAdPageById: () => ({
hasBeenViewed: () => true,
}),
getIndexById: () => 1,
hasId: () => true,
numberOfAdsCreated: () => 1,
};
const analyticsStub = env.sandbox.stub(autoAds, 'analyticsEvent_');
autoAds.handleActivePageChange_(1, 'i-amphtml-ad-page-1');
expect(analyticsStub).to.be.called;
expect(analyticsStub).to.have.been.calledWithMatch('story-ad-view', {
'viewTime': env.sandbox.match.number,
});
});
it('should fire "story-ad-exit" upon ad exit', () => {
autoAds.ampStory_ = {
element: storyElement,
addPage: NOOP,
};
autoAds.placementAlgorithm_ = {onPageChange: NOOP};
autoAds.visibleAdPage_ = {getId: () => 'page-1'};
autoAds.adPageManager_ = {
hasId: () => false,
numberOfAdsCreated: () => 1,
getIndexById: () => 1,
};
const analyticsStub = env.sandbox.stub(autoAds, 'analyticsEvent_');
autoAds.handleActivePageChange_(1, 'page-3');
expect(analyticsStub).to.be.called;
expect(analyticsStub).to.have.been.calledWithMatch('story-ad-exit', {
'exitTime': env.sandbox.match.number,
});
});
});
describe('development mode', () => {
it('should immediately insert and navigate to ad page', async () => {
storeGetterStub
.withArgs(StateProperty.CURRENT_PAGE_ID)
.returns('story-page-0');
const storyImpl = new MockStoryImpl(storyElement);
storyElement.getImpl = () => Promise.resolve(storyImpl);
await addStoryPages(doc, storyImpl);
adElement.id = 'i-amphtml-demo-1';
adElement.setAttribute('development', '');
const config = {
'a4a-conversion': true,
src: '/examples/amp-story/ads/app-install.html',
type: 'fake',
};
addStoryAutoAdsConfig(adElement, config);
env.sandbox
.stub(StoryAdPage.prototype, 'maybeCreateCta')
.resolves(/* success */ true);
await autoAds.buildCallback();
await autoAds.layoutCallback();
const adPageElement = doc.querySelector('#i-amphtml-ad-page-1');
const insertSpy = env.sandbox.spy(storyImpl, 'insertPage');
const dispatchStub = env.sandbox.spy(storyEvents, 'dispatch');
const ampAd = doc.querySelector('amp-ad');
ampAd.signals().signal(CommonSignals_Enum.INI_LOAD);
await macroTask();
expect(insertSpy).calledWith('story-page-0', 'i-amphtml-ad-page-1');
const payload = {
'targetPageId': 'i-amphtml-ad-page-1',
'direction': NavigationDirection.NEXT,
};
const eventInit = {bubbles: true};
expect(dispatchStub).calledWith(
win,
adPageElement,
storyEvents.EventType.SWITCH_PAGE,
env.sandbox.match(payload),
env.sandbox.match(eventInit)
);
});
});
}
);