Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test-example-validation.js hermetic #10154

Closed
dreamofabear opened this issue Jun 27, 2017 · 1 comment
Closed

Make test-example-validation.js hermetic #10154

dreamofabear opened this issue Jun 27, 2017 · 1 comment
Assignees
@dreamofabear
Labels
P2: Soon Type: Bug
Milestone
Fixit Week EOQ2

Comments

@dreamofabear
Copy link

To avoid breakages (and catch offending bugs earlier) due to validator releases, e.g. #10152.

Context:

amphtml/test/integration/test-example-validation.js

Line 21 in 5bb8318

// TODO(@cramforce): Use local version. This is non-hermetic

/cc @Gregable @cramforce
@dreamofabear dreamofabear added this to the Fixit Week EOQ2 milestone Jun 27, 2017
@dreamofabear dreamofabear self-assigned this Jun 27, 2017
This was referenced Jun 27, 2017
Closed
Merged
@rsimha
Copy link
Contributor

rsimha commented Jun 27, 2017

Looks like #9002 was opened to cover the same use case. @choumx, I'll assign it to you and let you dupe one, or fix both with your PR :)

@rsimha rsimha mentioned this issue Jun 27, 2017
Closed
@dreamofabear dreamofabear mentioned this issue Jun 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamofabear dreamofabear

Labels
P2: Soon Type: Bug
Projects
None yet
Milestone
Fixit Week EOQ2
Development

No branches or pull requests
2 participants
@dreamofabear @rsimha