Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve window.context API integration test coverage #10456

Closed
5 tasks done
jasti opened this issue Jul 14, 2017 · 1 comment
Closed
5 tasks done

Improve window.context API integration test coverage #10456

jasti opened this issue Jul 14, 2017 · 1 comment
Assignees
@lannka
Labels
WG: monetization
Projects
AMP Advertising
Milestone
Sprint H2 July

Comments

@jasti
Copy link
Contributor

jasti commented Jul 14, 2017 •
edited by lannka

  • context.data
  • context.location
  • context.sourceUrl
  • context.clientId
  • ad viewability APIs
@jasti jasti added this to the Sprint H2 July milestone Jul 14, 2017
@jasti jasti added this to Sprint Candidate in AMP Advertising Jul 14, 2017
@jasti jasti changed the title Have robust tests for users of AMP context API Create robust tests for users of AMP context API Jul 14, 2017
@lannka lannka changed the title Create robust tests for users of AMP context API Create an integration test for the window.context.data object Jul 21, 2017
@lannka
Copy link
Contributor

lannka commented Jul 21, 2017

@jasti FYI I re-scoped the issue to be more actionable for this sprint.

@lannka lannka mentioned this issue Jul 24, 2017
Merged
@lannka lannka closed this as completed Jul 25, 2017
@lannka lannka changed the title Create an integration test for the window.context.data object Improve window.context API integration test coverage Jul 25, 2017
@lannka lannka reopened this Jul 25, 2017
This was referenced Jul 25, 2017
Merged
Merged
@lannka lannka moved this from Sprint Candidate to Current Sprint in AMP Advertising Jul 28, 2017
@lannka lannka moved this from Current Sprint to Done in AMP Advertising Jul 31, 2017
@lannka lannka mentioned this issue Jul 31, 2017
Closed
@lannka lannka mentioned this issue Jan 2, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lannka lannka

Labels
WG: monetization
Projects
AMP Advertising
  
Done
Milestone
Sprint H2 July
Development

No branches or pull requests
2 participants
@jasti @lannka