Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifications re: experiments #1065

Closed
rudygalfi opened this issue Dec 3, 2015 · 3 comments
Closed

Clarifications re: experiments #1065

rudygalfi opened this issue Dec 3, 2015 · 3 comments

Comments

@rudygalfi
Copy link
Contributor

A question and few requests regarding AMP experiments.

Question: Is changing the settings at https://cdn.ampproject.org/experiments.html == using the console to do AMP.toggleExperiment('experiment-name')? If so, why does it seem like these are out of sync for me?

Requests:

[1] https://github.com/ampproject/amphtml/blob/master/tools/experiments/README.md says

Experiments UI is a available at:
https://cdn.ampproject.org/experiments.js

but it should say:

Experiments UI is a available at:
https://cdn.ampproject.org/experiments.html

[2] More info regarding the dev channel is not properly linked from https://cdn.ampproject.org/experiments.html. It should link to:

https://github.com/ampproject/amphtml/blob/master/DEVELOPING.md#amp-dev-channel-experimental

@dvoytenko
Copy link
Contributor

I fixed (1) and (2) in #1069.

Which URL are you trying to call AMP.toggleExperiment on? The experiment control is per-domain. The experiments.html page enables it for cdn.ampproject.org. AMP.toggleExperiment enables it for the current domain.

@rudygalfi
Copy link
Contributor Author

@dvoytenko Thanks for the fixes!

The URL was theguardian.com. Your explanation makes sense and answers my question.

I think the docs can be better. Something like:

An experiments UI is a available at to enable or disable content served from https://cdn.ampproject.org:
https://cdn.ampproject.org/experiments.html

For content served from any other domain, experiments can be toggled in the devtools console when development mode is enabled using:
AMP.toggleExperiment('experiment name')

@dvoytenko
Copy link
Contributor

#1070 is assigned to you for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants