Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all existing user() usage to element.user() #10891

Closed
lannka opened this issue Aug 11, 2017 · 7 comments
Closed

Migrate all existing user() usage to element.user() #10891

lannka opened this issue Aug 11, 2017 · 7 comments

Comments

@lannka
Copy link
Contributor

lannka commented Aug 11, 2017

For #6415

@lannka lannka added this to On Deck for Next Sprint in Analytics Aug 11, 2017
@rudygalfi rudygalfi moved this from On Deck for Next Sprint to In Progress This Sprint in Analytics Aug 22, 2017
@lannka lannka changed the title Migrate all existing user() usage to user(element) Migrate all existing user() usage to element.user() Aug 24, 2017
@rudygalfi
Copy link
Contributor

@tiendt Just wanted to confirm: Is this closed by #10858 or is this still other tasks pending?

@tiendt
Copy link
Contributor

tiendt commented Aug 25, 2017

@rudygalfi I still have another task pending!

@rudygalfi rudygalfi moved this from In Progress This Sprint to On Deck for Next Sprint in Analytics Aug 25, 2017
@rudygalfi rudygalfi moved this from On Deck for Next Sprint to In Progress This Sprint in Analytics Aug 25, 2017
This was referenced Aug 27, 2017
@lannka lannka assigned zhouyx and unassigned tiendt Sep 8, 2017
@lannka lannka added this to the Sprint H2 September milestone Sep 11, 2017
@rudygalfi rudygalfi moved this from In Progress This Sprint to On Deck for Next Sprint in Analytics Oct 3, 2017
@rudygalfi
Copy link
Contributor

@zhouyx I think we should schedule this soon. Do you have an estimate on the size of effort required?

@rudygalfi rudygalfi moved this from On Deck for Next Sprint to Sprint Candidate in Analytics Oct 27, 2017
@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @zhouyx Do you have any updates?

@lannka
Copy link
Contributor Author

lannka commented Jan 29, 2018

Let's bump its priority after the AMP Conf

@zhouyx
Copy link
Contributor

zhouyx commented Jul 2, 2019

This is a bigger of a change than I expected. The most difficult part is to handle helper function where there's no instance of element. cc @jeffjose on the prioritization.

@zhouyx zhouyx added this to Needs triage in Ads & Analytics issue triaging via automation Jul 2, 2019
@lannka lannka moved this from Needs triage to Triaged in Ads & Analytics issue triaging Jul 2, 2019
@stale
Copy link

stale bot commented Dec 23, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Dec 23, 2020
@stale stale bot closed this as completed Dec 31, 2020
Analytics automation moved this from Sprint Candidate to Done Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Analytics
  
Done
Development

No branches or pull requests

5 participants