Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write new visual diff tests for AMP components owned by @dvoytenko #11417

Closed
6 of 10 tasks
rsimha opened this issue Sep 25, 2017 · 21 comments
Closed
6 of 10 tasks

Write new visual diff tests for AMP components owned by @dvoytenko #11417

rsimha opened this issue Sep 25, 2017 · 21 comments
Assignees
Milestone

Comments

@rsimha
Copy link
Contributor

rsimha commented Sep 25, 2017

The following components owned by @dvoytenko do not have visual diff test coverage.

  • amp-access
  • amp-access-laterpay
  • amp-audio
  • amp-list
  • amp-mustache
  • amp-user-notification
  • amp-anim
  • amp-animation
  • amp-google-vrview-image
  • amp-image-lightbox

How to add a visual test:

  1. Create a simple test page for your component. You could use a portion of an existing page in examples/, or create a new one based on AMP by Example.
  2. Create a new directory in examples/visual-tests, for the test page (+ assets)
  3. Add an entry for the test page to test/visual-diff/visual-tests.json
  4. Create a PR and wait for it to be tested on Travis (the percy/amphtml check will fail)
  5. Click the details link and approve the Percy build that was generated on your PR branch
  6. Merge your PR and approve the next Percy build on master. Until you do so, master will be red, and this is expected.

Tip: Use #11413 as an example of how to add a new visual test. If your test page needs time to reach a steady state before a snapshot is taken, you can specify css classes that need to be visible, eventually appear, or eventually disappear. See test/visual-diff/visual-tests.json for examples.

Documentation: See this page on the AMP developer guide.

Master issue: #10155

@ampprojectbot
Copy link
Member

This issue doesn't have a category which makes it harder for us to keep track of it. @dvoytenko Please add an appropriate category.

15 similar comments
@ampprojectbot
Copy link
Member

This issue doesn't have a category which makes it harder for us to keep track of it. @dvoytenko Please add an appropriate category.

@ampprojectbot
Copy link
Member

This issue doesn't have a category which makes it harder for us to keep track of it. @dvoytenko Please add an appropriate category.

@ampprojectbot
Copy link
Member

This issue doesn't have a category which makes it harder for us to keep track of it. @dvoytenko Please add an appropriate category.

@ampprojectbot
Copy link
Member

This issue doesn't have a category which makes it harder for us to keep track of it. @dvoytenko Please add an appropriate category.

@ampprojectbot
Copy link
Member

This issue doesn't have a category which makes it harder for us to keep track of it. @dvoytenko Please add an appropriate category.

@ampprojectbot
Copy link
Member

This issue doesn't have a category which makes it harder for us to keep track of it. @dvoytenko Please add an appropriate category.

@ampprojectbot
Copy link
Member

This issue doesn't have a category which makes it harder for us to keep track of it. @dvoytenko Please add an appropriate category.

@ampprojectbot
Copy link
Member

This issue doesn't have a category which makes it harder for us to keep track of it. @dvoytenko Please add an appropriate category.

@ampprojectbot
Copy link
Member

This issue doesn't have a category which makes it harder for us to keep track of it. @dvoytenko Please add an appropriate category.

@ampprojectbot
Copy link
Member

This issue doesn't have a category which makes it harder for us to keep track of it. @dvoytenko Please add an appropriate category.

@ampprojectbot
Copy link
Member

This issue doesn't have a category which makes it harder for us to keep track of it. @dvoytenko Please add an appropriate category.

@ampprojectbot
Copy link
Member

This issue doesn't have a category which makes it harder for us to keep track of it. @dvoytenko Please add an appropriate category.

@ampprojectbot
Copy link
Member

This issue doesn't have a category which makes it harder for us to keep track of it. @dvoytenko Please add an appropriate category.

@ampprojectbot
Copy link
Member

This issue doesn't have a category which makes it harder for us to keep track of it. @dvoytenko Please add an appropriate category.

@ampprojectbot
Copy link
Member

This issue doesn't have a category which makes it harder for us to keep track of it. @dvoytenko Please add an appropriate category.

@ampprojectbot
Copy link
Member

This issue doesn't have a category which makes it harder for us to keep track of it. @dvoytenko Please add an appropriate category.

1 similar comment
@ampprojectbot
Copy link
Member

This issue doesn't have a category which makes it harder for us to keep track of it. @dvoytenko Please add an appropriate category.

@ampprojectbot
Copy link
Member

This issue doesn't have a category which makes it harder for us to keep track of it. @dvoytenko Please add an appropriate category.

@rsimha rsimha removed their assignment Jun 4, 2018
@ampprojectbot
Copy link
Member

This issue doesn't have a category which makes it harder for us to keep track of it. @dvoytenko Please add an appropriate category.

@dvoytenko
Copy link
Contributor

I added the visual tests for my components. However, amp-user-notification, amp-image-lightbox, etc - do not belong to me. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants