New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write new visual diff tests for AMP components owned by @erwinmombay #11424
Comments
thanks @rsimha-amp for the writeup! |
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
15 similar comments
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
1 similar comment
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
1 similar comment
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
This issue hasn't been updated in awhile. @erwinmombay Do you have any updates? |
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
2 similar comments
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
1 similar comment
This issue doesn't have a category which makes it harder for us to keep track of it. @erwinmombay Please add an appropriate category. |
The following components owned by @erwinmombay do not have visual diff test coverage.
How to add a visual test:
examples/
, or create a new one based on AMP by Example.percy/amphtml
check will fail)details
link and approve the Percy build that was generated on your PR branchmaster
will be red, and this is expected.Tip: Use #11413 as an example of how to add a new visual test. If your test page needs time to reach a steady state before a snapshot is taken, you can specify css classes that need to be visible, eventually appear, or eventually disappear. See test/visual-diff/visual-tests.json for examples.
Documentation: See this page on the AMP developer guide.
Master issue: #10155
The text was updated successfully, but these errors were encountered: