Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The attribute 'single-result' may not appear in tag 'amp-list'. #11518

Closed
dv336699 opened this issue Oct 2, 2017 · 2 comments
Closed

The attribute 'single-result' may not appear in tag 'amp-list'. #11518

dv336699 opened this issue Oct 2, 2017 · 2 comments

Comments

@dv336699
Copy link

dv336699 commented Oct 2, 2017

What's the issue?

Validator does not understand the single-result attribute.

How do we reproduce the issue?

  1. Open
    https://ampbyexample.com/playground/#url=https%3A%2F%2Fampbyexample.com%2Fcomponents%2Famp-list%2Fsource%2F
  2. Add single-result to the <amp-list.. - <amp-list single-result..
  3. Check the validator result

Which AMP version is affected?

Latest

@honeybadgerdontcare
Copy link
Contributor

#11236 introduced single-item even though the description and documentation state single-result. @jpettitt @aghassemi which is correct, the docs or the validator spec?

@dv336699
Copy link
Author

dv336699 commented Oct 2, 2017

@honeybadgerdontcare indeed, there is a single-item attr on the source at https://github.com/ampproject/amphtml/pull/11236/files#diff-f5fc5cf06a847b13f7ed34e58eda9d31R36

However, the source does create the single-result attribute to be used https://github.com/ampproject/amphtml/pull/11236/files#diff-cb5b59ffc6c4d1ed0c99e9f2b5d748b6R150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants