Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make viewability info available to amp-iframe #1158

Closed
cramforce opened this issue Dec 15, 2015 · 1 comment
Closed

Make viewability info available to amp-iframe #1158

cramforce opened this issue Dec 15, 2015 · 1 comment
Assignees
@camelburrito
Labels
INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code WG: monetization

Comments

@cramforce
Copy link
Member

amp-ad currently has a feature where iframes can request IntersectionObserver like information about whether they are currently in view or not.

This should be made available to amp-iframe and ideally generalized to all iframe based embeds (but can be in a follow up).
@cramforce
Copy link
Member Author

Relevant code is here
https://github.com/ampproject/amphtml/blob/master/builtins/amp-ad.js#L261

@camelburrito camelburrito added the INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code label Dec 18, 2015
@camelburrito camelburrito mentioned this issue Jan 14, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camelburrito camelburrito

Labels
INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code WG: monetization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cramforce @camelburrito