New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Master feature] Support RTL for amp-story #11647
Comments
This is harder no doubt... but would it be worth creating another issue to enable vertical instead of horizontal? At least one major language group expects that :) |
The visual diff tests added in #17110 show that many of the templated UIs need some love in RTL: The share menu actually looks okay: |
Yep, the share menu was just fixed in #17098 alongside the system layer. I am working on the remaining templated UIs. Thanks for including RTL in the visual diffs! |
Right now, everything is designed as LTR. This is a cover bug for enabling RTL support. We should consider the story to be RTL if:
dir
attribute set to"rtl"
direction
property of its computed style is"rtl"
document.dir
is set to"rtl"
If none of these are true, we should consider the story as LTR. We can calculate this once per story, at build time.
amp-story-consent
UI elements should be flippedThe text was updated successfully, but these errors were encountered: