Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome Extension: Extension stays broken if validator.js not loaded #12019

Closed
jamesshannon opened this issue Nov 10, 2017 · 1 comment · Fixed by #12733
Closed

Chrome Extension: Extension stays broken if validator.js not loaded #12019

jamesshannon opened this issue Nov 10, 2017 · 1 comment · Fixed by #12733

Comments

@jamesshannon
Copy link
Contributor

The extension wasn't working for me. Went through a bunch of debugging and made it to the background.js page, which was saying that the amp object is undefined (line 248: const validationResult = amp.validator.validateString(doc);). Network tab showed that when trying to download this there was an ERR_CONNECTION_REFUSED. I've been doing a lot of traveling recently, so I guess that I some point the extension started up and I didn't have internet.

This is somewhat brittle, as a momentary internet glitch caused the extension to be effectively broken until it's restarted (and there's no clear way to know this).

There should either be a note when hovering over the action button, or the background should try to redownload, or to do a network-then-cache strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants