Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator rejects aria-current="page" on a span. Correct? #12096

Closed
weeblrpress opened this issue Nov 17, 2017 · 1 comment · Fixed by #12102
Closed

Validator rejects aria-current="page" on a span. Correct? #12096

weeblrpress opened this issue Nov 17, 2017 · 1 comment · Fixed by #12102
Assignees

Comments

@weeblrpress
Copy link

What's the issue?

If an aria-current="page" is added to a span, as can now happen with WordPress + Yoast SEO, the AMP validator invalidates the page with a The attribute 'aria-current' may not appear in tag 'span' error message.

[EDIT]: I looked up https://github.com/ampproject/amphtml/blob/master/validator/validator-main.protoascii and it appears that aria-current is simply not whitelisted.

How do we reproduce the issue?

On a WordPress install, using Yoast SEO, a page that has pagination will cause this error. Can also be reproduced by adding the aria-current attribute to any element I think.

Which AMP version is affected?

Tested as of 2017-11-17

@aghassemi
Copy link
Contributor

@weeblrpress fix sent. will be in production in about 3 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants