Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate ui abuse of amp-user-notification #1224

Closed
erwinmombay opened this issue Dec 22, 2015 · 3 comments
Closed

Investigate ui abuse of amp-user-notification #1224

erwinmombay opened this issue Dec 22, 2015 · 3 comments
Assignees
@erwinmombay
Milestone
Backlog Bugs

Comments

@erwinmombay
Copy link
Member

@dvoytenko is concerned about maximum height etc. so we need to figure out what the best way to prevent user abuse.

Related:
#902
#1178
@erwinmombay erwinmombay self-assigned this Dec 22, 2015
@dvoytenko
Copy link
Contributor

My main concern here is actually ensuring that dismiss button is always visible and clickable.

@erwinmombay erwinmombay mentioned this issue Dec 22, 2015
Merged
4 tasks
@ericlindley-g ericlindley-g added this to the M2 milestone Feb 6, 2016
@rudygalfi rudygalfi modified the milestones: M2, Backlog Mar 4, 2016
@erwinmombay
Copy link
Member Author

@dvoytenko is it worthwhile to measure that ensure visibility etc on the runtime?

@dvoytenko
Copy link
Contributor

Yeah, we determined in other projects that this is no longer a concern.

@qidonna qidonna mentioned this issue Aug 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erwinmombay erwinmombay

Labels
None yet
Projects
None yet
Milestone
Backlog Bugs
Development

No branches or pull requests
4 participants
@erwinmombay @dvoytenko @rudygalfi @ericlindley-g