Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide AMP 3-dots loading indicator within amp-story #12916

Closed
newmuis opened this issue Jan 19, 2018 · 1 comment
Closed

Hide AMP 3-dots loading indicator within amp-story #12916

newmuis opened this issue Jan 19, 2018 · 1 comment
Assignees
@newmuis
Labels
P2: Soon Type: Bug WG: stories
Projects
Stories - By Type
Milestone
Sprint H2 January

Comments

@newmuis
Copy link
Contributor

newmuis commented Jan 19, 2018

amp-story does not benefit as much from the 3-dots loading indicator as a traditional AMP page. The current preferred UX it to actually just have no loading indicator, so we can simply hide the three dots.
@newmuis newmuis added this to the Active Non-Sprint Tracked milestone Jan 19, 2018
@newmuis newmuis added this to Developer Preview (Available) in Stories - By Type via automation Jan 19, 2018
@newmuis newmuis moved this from Developer Preview (Available) to Fixit in Stories - By Type Jan 19, 2018
@newmuis newmuis moved this from Fixit to Developer Preview (Pending) in Stories - By Type Jan 28, 2018
@newmuis newmuis assigned gmajoulet and unassigned prateekbh Jan 28, 2018
@newmuis newmuis moved this from Developer Preview (Pending) to Developer Preview (Available) in Stories - By Type Jan 28, 2018
@newmuis
Copy link
Contributor Author

newmuis commented Jan 28, 2018

This should be as simple as

amp-story .i-amphtml-loader {
  display: none !important;
}

@newmuis newmuis assigned newmuis and unassigned gmajoulet Jan 29, 2018
@newmuis newmuis mentioned this issue Jan 29, 2018
Merged
@newmuis newmuis moved this from Developer Preview (Available) to Developer Preview (Pending) in Stories - By Type Jan 29, 2018
@newmuis newmuis closed this as completed Jan 30, 2018
Stories - By Type automation moved this from Developer Preview (Pending) to Done Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@newmuis newmuis

Labels
P2: Soon Type: Bug WG: stories
Projects
Stories - By Type
  
Done
Milestone
Sprint H2 January
Development

No branches or pull requests
3 participants
@gmajoulet @newmuis @prateekbh