Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-system/exec.js : getOutput returns invalid object #12971

Closed
Galphimbl opened this issue Jan 23, 2018 · 6 comments
Closed

build-system/exec.js : getOutput returns invalid object #12971

Galphimbl opened this issue Jan 23, 2018 · 6 comments
Assignees

Comments

@Galphimbl
Copy link
Contributor

What's the issue?

build-system/exec.js : getOutput returns object with stdout === null && stderr === null

node -v
v8.9.4

yarn -v
1.3.2

gulp -v
[11:31:54] CLI version 3.9.1

How do we reproduce the issue?

  1. clone https://github.com/Galphimbl/amphtml
  2. run "yarn install" or "gulp"
@aghassemi
Copy link
Contributor

/to @rsimha-amp for triage

@aghassemi aghassemi added this to the Pending Triage milestone Jan 24, 2018
@rsimha
Copy link
Contributor

rsimha commented Jan 24, 2018

@Galphimbl Can you talk about where you are using getOutput? Is this being run as part of build-system/check-package-manager.js (which is run before yarn), or are you calling it somewhere else?

The recommended version of node for AMP development is v6. Could you try running nvm install 6 followed by yarn to see if the issue still repros?

@rsimha
Copy link
Contributor

rsimha commented Jan 24, 2018

I just switched to your versions and am not seeing the error. What OS are you running on? How are you calling the command? (getOutput pipes the stdout and stderr to the calling process)

image

@Galphimbl
Copy link
Contributor Author

Galphimbl commented Jan 25, 2018

@rsimha-amp My OS is windows 10.
Version: 1703
OS Build: 15063.850
System type: 64-bit operation system, x64-based processor

same issue on node v6.12.3
getOutput run as part of build-system/check-package-manager.js.
yarn

i can comment preinstall script and install all dependencies, but gulp also use this in build-system\tasks\update-packages.js:30:30
gulp

@rsimha
Copy link
Contributor

rsimha commented Jan 30, 2018

@Galphimbl Looks like we were starting a posix-only shell. #13156 should fix this.

@rsimha
Copy link
Contributor

rsimha commented Jan 31, 2018

@Galphimbl let me know if the fix works on windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants