Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JsDoc related lint warnings - round 1 #15312

Closed
6 tasks done
lannka opened this issue May 15, 2018 · 7 comments
Closed
6 tasks done

Fix JsDoc related lint warnings - round 1 #15312

lannka opened this issue May 15, 2018 · 7 comments
Assignees
@zhouyx @lannka @calebcordry
Labels
P2: Soon Type: Bug WG: analytics WG: monetization
Projects
AMP Advertising
Milestone
Sprint H2 May 2018

Comments

@lannka
Copy link
Contributor

lannka commented May 15, 2018 •
edited by calebcordry

Let's fix the following for round 1:

  • cid*.js
  • 3p/
  • extensions/amp-ad/
  • extensions/amp-analytics/
  • extensions/amp-story-auto-ads/
  • extensions/amp-sticky-ad/

Tip to run lint on selected files:

gulp lint --files=a.js,b.js,c.js

Please reply to this thread if you start work on any of them.
@lannka lannka added this to the Sprint H2 May 2018 milestone May 15, 2018
@lannka
Copy link
Contributor Author

lannka commented May 15, 2018

I'm taking care of the cid*.js now.

This was referenced May 23, 2018
Merged
Merged
@lannka
Copy link
Contributor Author

lannka commented May 23, 2018

I'm taking amp-analytics.

@zhouyx
Copy link
Contributor

zhouyx commented May 24, 2018

I'll take the amp-ad

@zhouyx zhouyx mentioned this issue May 24, 2018
Merged
@calebcordry
Copy link
Member

amp-story-auto-ads will be fixed with my incoming PR today

@lannka
Copy link
Contributor Author

lannka commented May 24, 2018

taking 3p/

@lannka lannka mentioned this issue May 24, 2018
Merged
@zhouyx
Copy link
Contributor

zhouyx commented Jun 15, 2018

@calebcordry Can we close this?

@calebcordry
Copy link
Member

Yep, sorry I forgot about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhouyx zhouyx

@lannka lannka

@calebcordry calebcordry

Labels
P2: Soon Type: Bug WG: analytics WG: monetization
Projects
AMP Advertising
  
Awaiting triage
Milestone
Sprint H2 May 2018
Development

No branches or pull requests
6 participants
@zhouyx @lannka @calebcordry @dreamofabear @ampprojectbot @adelinamart