Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update positioning of absolute elements in amp-story #19195

Closed
Enriqe opened this issue Nov 8, 2018 · 1 comment
Closed

Update positioning of absolute elements in amp-story #19195

Enriqe opened this issue Nov 8, 2018 · 1 comment
Assignees
@Enriqe
Labels
WG: stories
Projects
Stories - By Type

Comments

@Enriqe
Copy link
Contributor

Enriqe commented Nov 8, 2018

We sometimes position elements that take the whole width and height of their space by specifying:

top:0; left:0; bottom:0; right:0;

We should use: top: 0 left: 0 width: 100% height instead, since what we use now has some caused some bugs. e.g. #13433
@Enriqe Enriqe self-assigned this Nov 8, 2018
@Enriqe Enriqe added this to Incoming (Untriaged) in Stories - By Type via automation Nov 8, 2018
@Enriqe Enriqe mentioned this issue Nov 8, 2018
Merged
@newmuis
Copy link
Contributor

newmuis commented Nov 8, 2018

The bugs are only relating to grid areas, so I think we're probably okay.

@Enriqe Enriqe closed this as completed Nov 15, 2018
Stories - By Type automation moved this from Incoming (Untriaged) to Done Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Enriqe Enriqe

Labels
WG: stories
Projects
Stories - By Type
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@newmuis @Enriqe