Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Documentation for VARIANT and VARIANTS Variable Substibutions #19320

Closed
hadidotj opened this issue Nov 14, 2018 · 2 comments · Fixed by #23832
Closed

Missing Documentation for VARIANT and VARIANTS Variable Substibutions #19320

hadidotj opened this issue Nov 14, 2018 · 2 comments · Fixed by #23832
Assignees
@zhouyx
Labels
P3: When Possible Related to: Documentation WG: analytics
Projects
Ads & Analytics issue triaging Analytics Fixit (2019)
Milestone
Docs Updates

Comments

@hadidotj
Copy link

What's the issue?

The AMP HTML URL Variable Substitutions page is missing definitions for "VARIANT(experiment)" and "VARIANTS" as suggested by the link on the amp-experiment Reporting section.

Steps to Reproduce

  1. Navigate to the amp-experiment documentation, Reporting section
  2. Read that "VARIANT(experiment)" and "VARIANTS" are substitution variables, but the link provided-URL substitution variable-does not contain details on these variables as suggested.
@aghassemi
Copy link
Contributor

to @CrystalFaith

@aghassemi aghassemi added this to the Pending Triage milestone Nov 15, 2018
@zhouyx zhouyx added this to Needs triage in Ads & Analytics issue triaging via automation Jul 2, 2019
@zhouyx zhouyx moved this from Needs triage to Fixit in Ads & Analytics issue triaging Jul 2, 2019
@CrystalOnScript
Copy link
Contributor

Over to @zhouyx - thanks! :)

@zhouyx zhouyx added this to To do in Analytics Fixit (2019) via automation Aug 8, 2019
@zhouyx zhouyx mentioned this issue Aug 8, 2019
Merged
@zhouyx zhouyx moved this from To do to In progress in Analytics Fixit (2019) Aug 8, 2019
Ads & Analytics issue triaging automation moved this from Fixit to Closed Aug 8, 2019
Analytics Fixit (2019) automation moved this from In progress to Done Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhouyx zhouyx

Labels
P3: When Possible Related to: Documentation WG: analytics
Projects
No open projects
Ads & Analytics issue triaging
  
Closed
Analytics Fixit (2019)
  
Done
Milestone
Docs Updates
Development

Successfully merging a pull request may close this issue.

Add VARIANT doc to the variables list zhouyx/amphtml
5 participants
@aghassemi @hadidotj @zhouyx @ampprojectbot @CrystalOnScript