Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional test coverage to amp-consent CMP Fullscreen #19607

Closed
torch2424 opened this issue Dec 4, 2018 · 0 comments · Fixed by #19638
Closed

Add additional test coverage to amp-consent CMP Fullscreen #19607

torch2424 opened this issue Dec 4, 2018 · 0 comments · Fixed by #19638
Assignees
@torch2424
Labels
P2: Soon WG: analytics
Projects
Ads+Analytics Fixit Dec 2018
Milestone
Pending Triage

Comments

@torch2424
Copy link
Contributor

relates to #18910

This is a follow up issue to the comment made by @zhouyx 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@torch2424 torch2424

Labels
P2: Soon WG: analytics
Projects
No open projects
Ads+Analytics Fixit Dec 2018
  
Done
Milestone
Pending Triage
Development

Successfully merging a pull request may close this issue.

✨19607 Additonal Unit Tests for amp-consent-v2 enterFullscreen() torch2424/amphtml
2 participants
@torch2424 @ampprojectbot