Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease number of skipped tests #19766

Open
estherkim opened this issue Dec 10, 2018 · 5 comments
Open

Decrease number of skipped tests #19766

estherkim opened this issue Dec 10, 2018 · 5 comments

Comments

@estherkim
Copy link
Collaborator

No description provided.

@rsimha
Copy link
Contributor

rsimha commented May 30, 2019

Currently, there are ~200 skipped tests: https://github.com/ampproject/amphtml/search?q=.skip&type=Code

This is something that should probably be addressed by the entire team during fixit week.

@calebcordry calebcordry added this to Needs triage in Ads & Analytics issue triaging via automation Jul 2, 2019
@calebcordry calebcordry moved this from Needs triage to Fixit in Ads & Analytics issue triaging Jul 2, 2019
@rsimha rsimha added this to FixIt week in Infrastructure Jul 16, 2019
@lannka
Copy link
Contributor

lannka commented Aug 5, 2019

Ads team is working on it

@rsimha
Copy link
Contributor

rsimha commented Apr 30, 2020

From recent conversations about improving our release quality, we've talked about resurrecting the gulp todos* task to help reduce the number of TODOs in our codebase. Skipped tests typically have an accompanying TODO, so this is probably worth thinking of in conjunction with that larger effort.

@rsimha
Copy link
Contributor

rsimha commented Apr 22, 2021

[Infra triage] Putting this on the radar of @rileyajones. We recently added analytics for our tests via CircleCI. I wonder if the reporters can be made to enumerate skipped tests in the results, and if we can do anything with that information.

@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3: When Possible Stale Inactive for one year or more WG: infra
Projects
No open projects
Development

No branches or pull requests

6 participants