Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing a flag to disable origin checking on the local dev server #19997

Open
torch2424 opened this issue Dec 19, 2018 · 4 comments
Open
Assignees
Milestone

Comments

@torch2424
Copy link
Contributor

SSH Reverse proxying (think ngrok) is often used to expose a ports on a local machine, through a port on a VPS.

However, the dev server does some origin checking, and we have an allowed list to only allow certain origins for development. See the following:

https://github.com/torch2424/amphtml/blob/ecefc5f81ff9c1dd1555171a7d5000bdca6bcd1e/build-system/app.js#L193
https://github.com/torch2424/amphtml/blob/ecefc5f81ff9c1dd1555171a7d5000bdca6bcd1e/build-system/app.js#L1370

And here is a place where I make an API Call I want to go through:

https://github.com/ampproject/amphtml/blob/master/extensions/amp-consent/0.1/cmps.js#L33

We should offer a flag like --disable-origin-check in the gulp serve command, to allow the API to allow requests from any origin 😄

cc @erwinmombay

@rsimha
Copy link
Contributor

rsimha commented Apr 30, 2020

@alanorozco @erwinmombay Is this still relevant?

@erwinmombay
Copy link
Member

im not 100% sure, i can see the benefit of it i just don't know if we've circumvented/fixed the issue with all the server changes along the way

@rsimha
Copy link
Contributor

rsimha commented Apr 22, 2021

[Infra triage] Is this something we'd like to do? If not, can this be closed?

@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants