Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story templating improvements. #21661

Closed
gmajoulet opened this issue Apr 1, 2019 · 0 comments
Closed

Story templating improvements. #21661

gmajoulet opened this issue Apr 1, 2019 · 0 comments
Assignees
Labels
INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code P1: High Priority Type: Feature Request WG: stories

Comments

@gmajoulet
Copy link
Contributor

The goals of this project are to:

1. Provide an API to write media queries for a Story.

As of today, media queries don’t work for Stories, since the story element doesn’t always fit the viewport. Fixing this would make designing for stories and selecting assets a lot easier.

2. Provide a way to configure different assets (videos, images) depending on the story dimensions and orientation.

Having to pick assets that work for both landscape and portrait when designing a story is too restrictive.
Allowing publishers to write media queries enables them to show different versions of the same assets, based on the screen dimensions or orientation. However, we need to make sure we only preload what’s necessary, and fix how our code reacts to orientation or dimensions changes while media elements are playing.
We need to change the way we preload assets so we have better control over it.

3. Provide an API to control how assets (videos, images) are cropped.

Today, we force publishers to pick assets where the point of interest is perfectly centered, which is very restrictive. They need to be able to provide cropping information for their assets, so the interesting part of the asset stays visible, no matter the screen dimensions or orientation.

4. Design an API to start allowing pre-templated UIs

We want to design an API that lets us introduce many pre-templated UIs, starting with the “landscape half-half” - that we believe makes it easier to design for the immersive landscape experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code P1: High Priority Type: Feature Request WG: stories
Projects
Stories - By Effort
XL (11+ days)
Development

No branches or pull requests

2 participants