Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amp-sidebar: Have the mask fade in #21973

Closed
torch2424 opened this issue Apr 25, 2019 · 2 comments 路 Fixed by #24204
Closed

amp-sidebar: Have the mask fade in #21973

torch2424 opened this issue Apr 25, 2019 · 2 comments 路 Fixed by #24204
Labels
Component: amp-sidebar P2: Soon Type: Feature Request Type: UX issues impacting end user experience WG: components
Projects
UI - Component UI - Type UI - Effort

Comments

@torch2424
Copy link
Contributor

torch2424 commented Apr 25, 2019 •
edited

Currently, the amp-sidebar mask doesn't fade in. I think the fade should be something smooth to ease the user into the side bar mode, especially since the sidebar element has a nice transition.

Wanna take a vote @andrewwatterson ? 馃槃

cc @sparhami
@torch2424 torch2424 self-assigned this Apr 25, 2019
@andrewwatterson
Copy link
Contributor

I'm into it. Anecdotally, we got more comments about amp-sidebar at AMP Conf than any other single component, and @aghassemi mentioned it may be up for a new coat of paint. Do we... tag this issue in some way so that we can find it when it gets to be painting time?

@aghassemi aghassemi added this to Better Sidebar in Components - Projects Apr 25, 2019
@aghassemi
Copy link
Contributor

Le's track them in Better Sidebar in UI - Future Wishlist Project. added.

@aghassemi aghassemi assigned aghassemi and unassigned torch2424 Apr 25, 2019
@aghassemi aghassemi added this to amp-sidebar in UI - Component Apr 25, 2019
@aghassemi aghassemi removed their assignment Jun 17, 2019
@aghassemi aghassemi added Component: amp-sidebar Type: UX issues impacting end user experience labels Jun 22, 2019
@leafsy leafsy mentioned this issue Aug 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: amp-sidebar P2: Soon Type: Feature Request Type: UX issues impacting end user experience WG: components
Projects
No open projects
UI - Component
amp-sidebar
UI - Effort
Awaiting triage
UI - Type
Awaiting triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

馃枍 Make sidebar mask fade in/out and increase opacity leafsy/amphtml
4 participants
@andrewwatterson @torch2424 @aghassemi @dreamofabear