Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尭 Cherry pick request for #24017 into #23939 (Approved) #24020

Closed
Enriqe opened this issue Aug 16, 2019 · 3 comments
Closed

馃尭 Cherry pick request for #24017 into #23939 (Approved) #24020

Enriqe opened this issue Aug 16, 2019 · 3 comments
Assignees
Labels

Comments

@Enriqe
Copy link
Contributor

Enriqe commented Aug 16, 2019

Cherry-pick request

Issue PR Production? RC? Release issue
#24017 #24013 YES YES #23939 #23822

Why does this issue meet the cherry-pick criteria?

Some AMP Story-specific analytics events aren't being logged, in particular in the first page. This is messing with critical metrics for publishers. For example: bounce rates, completion rates, story progress...

Mini-postmortem

Early analytic events (e.g. story-page-visible when visiting the first page) weren't being logged correctly since the amp-analytics service wasn't being initialized on time to handle these events properly.

This has been happening since #23030 was pushed; as it stopped buffering early events and delaying their handling.

Summary

Due to a change where we stopped waiting for the <amp-analytics> service to be up before handling the events.

Root Causes

  1. 馃搱 Initial StorySpec Implementation聽#23030

Action Items

Action Item Type Owner PR #
Add integration tests Prevent @Enriqe #24310

Lessons Learned

  • We need integration / e2e tests for analytics.
  • We need to monitor our dashboards more often.

Things that went well

  • Not all analytics events were affected.

Things that went wrong

  • The issue went unnoticed for a month. We only noticed from a report.

/cc @ampproject/wg-approvers @ampproject/cherry-pick-approvers

@Enriqe Enriqe added the Type: Release Used to track AMP releases from canary to production label Aug 16, 2019
@dvoytenko
Copy link
Contributor

Approved.

@Enriqe Enriqe changed the title 馃尭 Cherry pick request for #24017 into #23939 (Pending) 馃尭 Cherry pick request for #24017 into #23939 (Approved) Aug 16, 2019
@dvoytenko dvoytenko assigned Enriqe and unassigned cramforce and dvoytenko Aug 16, 2019
@dvoytenko
Copy link
Contributor

Back to @Enriqe for postmortem.

@Enriqe
Copy link
Contributor Author

Enriqe commented Aug 30, 2019

Filled out PM and next steps to prevent this type of issue in the future. Closing, but feel free to re-open if I missed something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants