Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove amp-ad-exit logic from Story Ads #24080

Open
calebcordry opened this issue Aug 20, 2019 · 1 comment
Open

Remove amp-ad-exit logic from Story Ads #24080

calebcordry opened this issue Aug 20, 2019 · 1 comment

Comments

@calebcordry
Copy link
Member

In #24044 I will be introducing some logic into amp-story-auto-ads that will look for an amp-ad-exit config and if it exists, try to extract an url for the CTA click.

This was introduced as a temporary solution until we have first class support from our partner ad networks.

To delete this code we will need ad networks to support writing click tracking urls directly into the meta tag that story ads try to read
<meta name="amp-cta-url" content="<CLICK_TRACKING_URL">

cc/ @ampproject/wg-ads

@stale
Copy link

stale bot commented Feb 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Feb 20, 2021
@calebcordry calebcordry added this to the 3P Implementation milestone Feb 20, 2021
@stale stale bot removed the Stale Inactive for one year or more label Feb 20, 2021
@calebcordry calebcordry removed this from the 3P Implementation milestone Feb 20, 2021
@calebcordry calebcordry added this to To do in wg-monetization fixit week 2/2021 via automation Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants