Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix amp-orientation-observer demos #24400

Closed
wassgha opened this issue Sep 6, 2019 · 0 comments · Fixed by #24606
Closed

Fix amp-orientation-observer demos #24400

wassgha opened this issue Sep 6, 2019 · 0 comments · Fixed by #24606
Assignees
@wassgha
Labels
Component: amp-orientation-observer Customer: Developer P3: When Possible Type: Bug Type: DevX issues impacting developer experience WG: components

Comments

@wassgha
Copy link
Contributor

wassgha commented Sep 6, 2019

A lot of the demos from the amp-orientation-observer codepen don't work correctly.

/cc @nainar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wassgha wassgha

Labels
Component: amp-orientation-observer Customer: Developer P3: When Possible Type: Bug Type: DevX issues impacting developer experience WG: components
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨Adds smoothing to amp-orientation-observer wassgha/amphtml
2 participants
@wassgha @nainar