Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout attribute console error in test-amp-story. #24762

Closed
gmajoulet opened this issue Sep 26, 2019 · 0 comments · Fixed by #24824
Closed

Layout attribute console error in test-amp-story. #24762

gmajoulet opened this issue Sep 26, 2019 · 0 comments · Fixed by #24824

Comments

@gmajoulet
Copy link
Contributor

Layout attribute console error in test-amp-story:

ERROR: 'The element did not specify a layout attribute. Check https://amp.dev/documentation/guides-and-tutorials/develop/style_and_layout/control_layout and the respective element documentation for details.'
    The test "amp-story   amp-story consent should pause the story if there is a consent" resulted in a call to console.error. (See above line.)
    ⤷ If the error is not expected, fix the code that generated the error.
    ⤷ If the error is expected (and synchronous), use the following pattern to wrap the test code that generated the error:
        'allowConsoleError(() => { <code that generated the error> });'
    ⤷ If the error is expected (and asynchronous), use the following pattern at the top of the test:
        'expectAsyncConsoleError(<string or regex>[, <number of times the error message repeats>]);'

This error is triggered by the amp-story consent test cases.
It looks like the created amp-consent AMP component does not have a layout (see: supported layouts).

@gmajoulet gmajoulet self-assigned this Sep 26, 2019
@gmajoulet gmajoulet added this to Incoming (Untriaged) in Stories - By Type via automation Sep 26, 2019
@gmajoulet gmajoulet added this to Untriaged in Stories - By Effort via automation Sep 26, 2019
Stories - By Type automation moved this from Incoming (Untriaged) to Done Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants