You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In PR #24864, only one file is being changed. A validator .protoascii file. @Gregable approved this change yet the owners bot is showing a failure. Does this file need an additional approver despite a member of @ampproject/wg-caching approving it or is the bot not checking again after an approval? I do notice that the amp-owners-bot ran 2h+ ago and @Gregable approval is only 1h+ ago.
amp-owners-bot / ampproject/owners-check started 2h 13m 31s ago
Missing required OWNERS approvals! Suggested reviewers:
Missing required OWNERS approvals! Suggested reviewers:
DETAILS
Current Coverage
[NEEDS APPROVAL] extensions/amp-youtube/validator-amp-youtube.protoascii (requested: andrewwatterson)
Suggested Reviewers
For a description of the OWNERS.yaml file syntax, see this example YAML file.
The text was updated successfully, but these errors were encountered:
Yesterday I was working with the firewall configuration on the owners bot GCE project, and as a result there were a few blackout periods where the owners bot was blocked from receiving GitHub webhooks. The owners bot will normally run after any new commit is pushed, any reviewer is added, or any review is left. It was only because of this brief downtime that it was not triggered (I triggered it just now by adding and removing myself as a reviewer).
The actual deployed version of the owners bot, as a result of the way the project started in one repo and was migrated to another, is in a semi-fragile state at the moment. An effort is underway to clean up this process so it's A) automated and B) reliable. Normally I only perform updates on weekends/after-hours, but I broke that convention to push a bugfix.
Closing this issue since it was a one-off caused by a configuration change.
@rcebulko
In PR #24864, only one file is being changed. A validator
.protoascii
file. @Gregable approved this change yet the owners bot is showing a failure. Does this file need an additional approver despite a member of @ampproject/wg-caching approving it or is the bot not checking again after an approval? I do notice that the amp-owners-bot ran 2h+ ago and @Gregable approval is only 1h+ ago.The text was updated successfully, but these errors were encountered: