Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation error if amp-list references an template #2517

Closed
sebastianbenz opened this issue Mar 9, 2016 · 5 comments
Closed

Validation error if amp-list references an template #2517

sebastianbenz opened this issue Mar 9, 2016 · 5 comments
Assignees

Comments

@sebastianbenz
Copy link
Contributor

The following sample results in a validation errors (but works):

<amp-list width=300
      height=100
      layout=responsive
      src="https://ampbyexample.com/json/examples.json"
      template="amp-template-id">
  </amp-list>

Validation error:

validator.js:330 http://localhost:8000/components/amp-list/:1682:12 The attribute 
'template' may not appear in tag 'amp-list'. (see https://www.ampproject.org/docs/reference/extended/amp-list.html)

According to the docs the template attribute is supported.

Example page: https://ampbyexample.com/components/amp-list/?development=1

//cc @Gregable @dvoytenko

@dvoytenko
Copy link
Contributor

@Gregable PTAL. template attribute should be allowed as per https://github.com/ampproject/amphtml/blob/master/extensions/amp-list/amp-list.md#usage

@rudygalfi
Copy link
Contributor

@Gregable Have you had a chance to look at this?

@rudygalfi rudygalfi added this to the Sprint 2016-03-31 [current] milestone Mar 24, 2016
@Gregable
Copy link
Member

Will have this in the next release.

@rudygalfi
Copy link
Contributor

Closed via #2711.

@Gregable
Copy link
Member

FYI, this will be visible on the cdn.ampproject.org validator in about an hour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants