Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amphtml-validator: avoid breaking API changes in patch releases #25189

Closed
sebastianbenz opened this issue Oct 22, 2019 · 2 comments
Closed

amphtml-validator: avoid breaking API changes in patch releases #25189

sebastianbenz opened this issue Oct 22, 2019 · 2 comments
Labels
Type: Bug WG: caching

Comments

@sebastianbenz
Copy link
Contributor

The latest amphtml-validator npm release 1.0.26 upgraded the required node version from 10 to 12 which is a breaking API change. We should only do these by also increasing the major version to avoid breaking downstream clients.
@estherkim
Copy link
Collaborator

@sebastianbenz, agreed with the intent. However the node upgrade hasn't been published yet; it's misleading but 1.0.26 was released on 18 Oct while node was upgraded on 21 Oct.

@honeybadgerdontcare
Copy link
Contributor

Resolved via #25208

@rsimha rsimha mentioned this issue Jan 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug WG: caching
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sebastianbenz @honeybadgerdontcare @estherkim