Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator incorrectly accepts layout=fixed_height #25320

Closed
ithinkihaveacat opened this issue Oct 29, 2019 · 1 comment · Fixed by #32890
Closed

Validator incorrectly accepts layout=fixed_height #25320

ithinkihaveacat opened this issue Oct 29, 2019 · 1 comment · Fixed by #32890

Comments

@ithinkihaveacat
Copy link
Contributor

The JS validator at https://validator.amp.dev (incorrectly) considers components with layout fixed_height valid. (This should be written fixed-height.) The validator used in the Google AMP cache does not.

Example doc with layout=fixed_height that is rejected by the Google validator (as expected), but accepted by the JS validator (unexpected): https://brash-grease.glitch.me/

Identical page except with layout=fixed-height for comparison: https://picayune-yttrium.glitch.me/

/cc @Gregable

@honeybadgerdontcare
Copy link
Contributor

This is also true of flex_item, which should be flex-item. It appears the JavaScript engine is changing - in layout to _.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants