Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics: Cookie writer to support custom SameSite value #26361

Closed
zhouyx opened this issue Jan 15, 2020 · 9 comments · Fixed by #31365
Closed

Analytics: Cookie writer to support custom SameSite value #26361

zhouyx opened this issue Jan 15, 2020 · 9 comments · Fixed by #31365

Comments

@zhouyx
Copy link
Contributor

zhouyx commented Jan 15, 2020

@ryanashcraft @pierre-b @leazus @misteryeo @colmsnowplow
Please let us know if there's request to change the SameSite value when setting cookie using the AMP provided cookie writing feature. Thanks.

@pierre-b
Copy link
Contributor

Hi @zhouyx , thanks for asking, we don't need this feature at the moment. We use the AMP cookie to persist the AMP cid until the user exits the Google CDN and lands on the real domain with the linker (cid in URL).

@zhouyx
Copy link
Contributor Author

zhouyx commented Jan 16, 2020

Thank you @pierre-b

All, I'm going to label this issue P2 for now. But please do let us know if this feature is important for your business. We can prioritize it with the Chrome 80 launch approaching. Thanks.

@colmsnowplow
Copy link
Contributor

colmsnowplow commented Jan 29, 2020

Thanks for asking @zhouyx , and apologies for late response.

We've instrumented our design around avoiding dependence on cookies for user identification as far as possible. As long as the AMP client ID is reliable, we're all good!

@leazus
Copy link
Contributor

leazus commented Jan 30, 2020

Hi @zhouyx,
Sorry for the late response, and of course thank you for asking!
Currently, we don't need to apply the sameSite attribute for the AMP cookie (we use the CID and linker to pass it as a URL param)

@zhouyx
Copy link
Contributor Author

zhouyx commented Jan 30, 2020

Thank you all for the response. That's also what I heard from Google Analytics. Given the feedback setting the priority to P3.

@gui-poa
Copy link

gui-poa commented Aug 28, 2020

Hi, all. I don't know if I am in the right issue.

I need to add cookieFlags with "secure;samesite=none" on AMP pages, because I have an iframe on a 3d party domain that should read the GA cookie from the first party domain. This stopped to work recently. (mid august)

Is it possible to add this attribute currently? It did not work when I added on "vars".

Thanks!

@zhouyx
Copy link
Contributor Author

zhouyx commented Aug 28, 2020

Hi @gui-poa Thanks for reaching out.

We haven't added the sameSite and secure option to the cookieWriter config because there was no request to that. I think we should add that. Do you think if you can help with the code change? Let me know. Thanks!

@gui-poa
Copy link

gui-poa commented Aug 28, 2020

Hi, @zhouyx . Thanks for your reply! Unfortunately I do not have enough knowledge to help here.

Do you think it can be placed as p1? The regular version already supports Cookie Flags and we are currently without coverage of these flags for AMP, generating loss of data.

@zhouyx
Copy link
Contributor Author

zhouyx commented Aug 28, 2020

Understood. I can placed the issue as a P1. But I can't guarantee a timeline for this item. I'll pick it up asap. In the meantime, I'm more than happy to help if anyone could help with the code change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants