Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-script: Size-changing DOM mutations on initial load #26375

Closed
dreamofabear opened this issue Jan 16, 2020 · 0 comments · Fixed by #26401
Closed

amp-script: Size-changing DOM mutations on initial load #26375

dreamofabear opened this issue Jan 16, 2020 · 0 comments · Fixed by #26401

Comments

@dreamofabear
Copy link

Height-changing mutations can occur during worker-dom's "hydrating" phase (the first set of mutations), which can violate content jumping rules for amp-script[layout=container].

IOW, this line is wrong:

// Hydration is always allowed.
phase != Phase.MUTATING ||

Instead, it should check whether the set of mutations contains DOM changes (e.g. attribute/child mutations, not addEventListener).

Thanks @morsssss for pointing this out. /cc @kristoferbaxter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant