Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose ampTrust property with amp-carousel v2 slideChange event #27082

Closed
caroqliu opened this issue Mar 4, 2020 · 5 comments · Fixed by #31498
Closed

Expose ampTrust property with amp-carousel v2 slideChange event #27082

caroqliu opened this issue Mar 4, 2020 · 5 comments · Fixed by #31498
Assignees
@dmanek
Labels
Component: amp-carousel good first issue P2: Soon Type: Feature Request WG: components
Projects
wg-components Starter Issues

Comments

@caroqliu
Copy link
Contributor

caroqliu commented Mar 4, 2020

Describe the new feature or change to an existing feature you'd like to see

amp-carousel v1 recently exposed this property in #26991 and amp-carousel v2 should as well to keep this behavior consistent across versions.

Describe alternatives you've considered

Keep this behavior inconsistent across versions: this is bad for devx.

Additional context

This is a "good first issue"! The change would involve replicating the change in the PR linked above, except in amp-carousel v2. This change should only apply to carousel with type="slides".
@caroqliu caroqliu mentioned this issue Mar 4, 2020
Merged
@atharvasune
Copy link
Contributor

Hi i am new here, if this issue is still open and available to work on i would like to work on it

@caroqliu
Copy link
Contributor Author

Sure thing! Thanks for volunteering!

@atharvasune
Copy link
Contributor

I ll start working on this then 🙂

@atharvasune
Copy link
Contributor

hi, i had some doubts regarding writing tests , could you please help 😅 ?

@atharvasune atharvasune mentioned this issue May 28, 2020
Closed
@caroqliu caroqliu added this to Actions and Events in wg-components Starter Issues Oct 12, 2020
@dmanek
Copy link
Contributor

dmanek commented Dec 7, 2020

This issue has been dormant for a while. Assigning to myself. Will build on @atharvasune's PR.

@dmanek dmanek assigned dmanek and unassigned atharvasune Dec 7, 2020
This was referenced Dec 7, 2020
Closed
Merged
@caroqliu caroqliu moved this from Actions and Events to Done in wg-components Starter Issues Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmanek dmanek

Labels
Component: amp-carousel good first issue P2: Soon Type: Feature Request WG: components
Projects
wg-components Starter Issues
Done
Milestone
No milestone
3 participants
@dmanek @caroqliu @atharvasune