Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amp-fit-text:1.0] Bento tracking issue #28281

Closed
11 tasks done
caroqliu opened this issue May 8, 2020 · 1 comment
Closed
11 tasks done

[amp-fit-text:1.0] Bento tracking issue #28281

caroqliu opened this issue May 8, 2020 · 1 comment
Assignees
Projects

Comments

@caroqliu
Copy link
Contributor

caroqliu commented May 8, 2020

High-level requirements

Consideration Ready when Status
Component compatibility Conformance with 0.1 (see below)
Testing Unit tests and e2e tests from 0.1
Internationalization n/a n/a
Analytics n/a n/a
Accessibility Audit performed, 0.1 for reference
Page experience Audit performed
Documentation Written
Storybook Samples written

Component compatibility

Attributes to support:

  • min-font-size
  • max-font-size

Migration Notes:

  • 1.0 resizes to clientHeight and clientWidth, whereas 0.1 resize to offsetHeight and offsetWidth. The difference here is the exclusion of margins and borders from the fit-text coverage area.

Open tasks:

@caroqliu caroqliu changed the title [amp-fit-text:0.2] Bento tracking issue [amp-fit-text:1.0] Bento tracking issue May 8, 2020
@dvoytenko
Copy link
Contributor

Added task:

Remove constant line-height.

@caroqliu caroqliu added this to Tracking Issues in Bento Oct 8, 2020
@caroqliu caroqliu self-assigned this Oct 30, 2020
@caroqliu caroqliu moved this from Tracking Issues to Developer Preview in Bento Jun 7, 2021
Bento automation moved this from Developer Preview to Done Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Bento
  
Done
Development

No branches or pull requests

2 participants