🚨 Error: null is not an object (evaluating 'a.getBoundingClientRect')

[ampprojectbot]

Details

Error report: link
First seen: Apr 12, 2020
Frequency: ~ 15,433/day

Stacktrace

Error: null is not an object (evaluating 'a.getBoundingClientRect')
    at content (src/service/viewport/viewport-binding-ios-embed-wrapper.js:252:21)
    at src/service/viewport/viewport-impl.js:321:11
    at src/service/resources-impl.js:744:38
    at state (src/service/vsync-impl.js:470:25)
    at tasks (src/service/vsync-impl.js:418:23)
    at src/pass.js:109:4
    at src/pass.js:55:6
    at callback (src/service/timer-impl.js:83:8)

Notes

@choumx modified src/service/viewport/viewport-binding-ios-embed-wrapper.js:250-262 in #22718 (Jun 11, 2019)
@peterjosling modified src/service/viewport/viewport-impl.js:320-323 in #12229 (Dec 4, 2017)
@peterjosling modified src/service/resources-impl.js:744-745 in #12229 (Dec 4, 2017)
@jridgewell modified src/service/vsync-impl.js:470-471 in #20836 (Feb 14, 2019)
@jridgewell modified src/pass.js:105-112 in #3513 (Jun 9, 2016)
@cramforce modified src/service/timer-impl.js:81-88 in #7363 (Feb 7, 2017)

Seen in:

• 05-05 Beta (0322+1)
• 05-05 Control (0322+1)
• 05-05 Stable (0322+1)
• 05-05 Experiment-A (0322+1)
• 05-05 Experimental (0322+1)
• 05-05 Control (0322+2)
• 05-05 Stable (0322+2)
• 05-05 Nightly-Control (0322+2)
• 05-08 Beta (0549)
• 05-08 Experiment-A (0549)
• 05-08 Experimental (0549)
• 05-08 Beta (0549+1)
• 05-12 Nightly (2316)

Possible assignees: @choumx, @jridgewell

/cc @ampproject/release-on-duty

[rcebulko]

First seen date appears misleading, as the graph shows a big spike around May 12, right after 05-12 Nightly (2316) appeared, and at the same time as the cherry-pick release 0322+1 came out. It's hard to be certain, though, due to how the graphs have been truncated by Stackdriver. This cherry-pick (request) is linked to #28306, which was a reversion of #28043. It was performed the afternoon of May 11

There's no obvious recent change/culprit based on the stacktrace blame, but the timing seems too closely linked to be coincidence.

/cc @choumx

[dreamofabear]

Thanks for the initial investigation. Since the PR above is just a reversion to old behavior, this was likely an existing error. The offending line also implies that document.body is null, which is strange/exceptional behavior that probably can add a simple guard against.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.