Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尭 Cherry-pick request for #28440 into #28389 (Pending) #28441

Closed
gmajoulet opened this issue May 15, 2020 · 2 comments
Closed

馃尭 Cherry-pick request for #28440 into #28389 (Pending) #28441

gmajoulet opened this issue May 15, 2020 · 2 comments

Comments

@gmajoulet
Copy link
Contributor

Cherry-pick request

Issue PR Beta / Experimental? Stable? LTS? Release issue
#28440 #28440 YES YES YES #28223 #28389

Why does this issue meet the cherry-pick criteria?

Story navigation is completely blocked after prerendering when using #cap=education.

Mini-postmortem

TODO: This postmortem will be written after the cherry-pick deployment and before this issue is closed. Delete this TODO when the postmortem is ready.

Summary

The pointer-events: none; CSS rule on the amp-story-education element is somehow ignored after a prerender, and acts like a click shield preventing any navigation, so we display: none; instead.

Impact

  • All players using #cap=education

Action Items

  • #<ISSUE_NUMBER>: <Add unit/integration/end-to-end test>
  • #<ISSUE_NUMBER>: <Add monitoring for edge case via error logging>
  • #<ISSUE_NUMBER>: <Refactor an easily misused API>

/cc @ampproject/release-on-duty @ampproject/wg-approvers @ampproject/cherry-pick-approvers

@cramforce
Copy link
Member

Approved. Low-risk change into unlaunched (but launching) feature.

@powerivq
Copy link
Contributor

Cherry pick on stable 2d71cd2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants