Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尭 Cherry-pick request for #30285 into #2009142129000 (Approved) #30286

Closed
zhouyx opened this issue Sep 17, 2020 · 5 comments
Closed

馃尭 Cherry-pick request for #30285 into #2009142129000 (Approved) #30286

zhouyx opened this issue Sep 17, 2020 · 5 comments
Assignees
Labels
Cherry-pick: Beta Cherry-pick: Experimental Type: Release Used to track AMP releases from canary to production

Comments

@zhouyx
Copy link
Contributor

zhouyx commented Sep 17, 2020

Cherry-pick request

Issue PR Beta / Experimental? Stable? LTS? Release issue
#30285 #30284 Only AMPHTML Ad Beta No No #<RELEASE_ISSUE>

Why does this issue meet the cherry-pick criteria?

#30285 caused visibility loss when an inabox ad resize in viewport

Why is a Beta / Experimental cherry-pick not needed?

We're only cherrypicking to the AMPHTML ad release version, since it's not affecting AMP documents. (No resize within viewport)

Mini-postmortem

Summary

We recently added a check to element's size before sending visibility request. This lead to an issue when an element resize without intersectionRatio change.

Impact

This leads to visibility loss for inabox ads that resize from 0 within the viewport.

Action Items

  • Revert the change to add size zero change
  • Add the size check back, but for the inabox case add 'resize' listener to the iframe window
  • Have visibility trigger listen to both InteresectionObserver and ResizeObserver if possible

/cc @ampproject/release-on-duty @ampproject/wg-approvers @ampproject/cherry-pick-approvers

to @ampproject/wg-ads @jeffkaufman @lannka @powerivq

@zhouyx
Copy link
Contributor Author

zhouyx commented Sep 17, 2020

#30284 has been merged.

@zhouyx
Copy link
Contributor Author

zhouyx commented Sep 17, 2020

cherry-pick to AMPHTML ad release only. to @lannka for approval. cc @jeffkaufman

@lannka
Copy link
Contributor

lannka commented Sep 18, 2020

approved

@zhouyx
Copy link
Contributor Author

zhouyx commented Sep 18, 2020

version 2009142129001 has been released. Will promote it to inabox RC next Monday during business hours.

@zhouyx zhouyx changed the title 馃尭 Cherry-pick request for #30285 into #2009142129000 (Pending) 馃尭 Cherry-pick request for #30285 into #2009142129000 (Approved) Sep 21, 2020
@zhouyx
Copy link
Contributor Author

zhouyx commented Sep 21, 2020

2009142129001 has been released to inabox RC.

@zhouyx zhouyx closed this as completed Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cherry-pick: Beta Cherry-pick: Experimental Type: Release Used to track AMP releases from canary to production
Projects
None yet
Development

No branches or pull requests

2 participants