Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<amp-base-carousel>: buggy when advance-count = 1 and visible-count > 1 #30905

Closed
dero opened this issue Oct 29, 2020 · 2 comments · Fixed by #30963
Closed

<amp-base-carousel>: buggy when advance-count = 1 and visible-count > 1 #30905

dero opened this issue Oct 29, 2020 · 2 comments · Fixed by #30963

Comments

@dero
Copy link

dero commented Oct 29, 2020

What's the issue?

See this pen in a desktop browser: https://codepen.io/iamdero/pen/bGeLPqy

  1. Click the next button and observe the carousel animation to advance by one slide to slide nr. 2 (correct)
  2. ... but then immediately advance again with no animation to slide nr. 3 (incorrect).
  3. Click the next button, the carousel will not advance (incorrect).
  4. Click the next button yet again, it will advance by two slides (incorrect).
  5. Click the back button, carousel will go back by two slides (incorrect)
  6. ... and then immediately swap the slides so that the final result is as if it only went back by one slide (correct).

What browsers are affected?

Desktop browsers, tested in latest Chrome and Firefox.

Which AMP version is affected?

Powered by AMP ⚡ HTML – Version 2010132225002

@micajuine-ho
Copy link
Contributor

Hi @dero, I am testing this locally but I am unable to reproduce this error. Are you able to reproduce this outside of codepen.io environment?

@dero
Copy link
Author

dero commented Nov 1, 2020

Hi @micajuine-ho – thanks for the quick reply!

Yes, I've encountered the issue on a project I'm working on and the issue is still there. The project is not live yet and is not shareable ATM, but the issue is identical to what the pen shows.

I've also taken the code and ran it on a local webserver and the issue is still there.

I am unable to reproduce this error.

Are you able to verify and reproduce the issue on codepen?

Any chance you're using newer / dev version of amp-base-carousel where this issue might already be fixed? The currently live version – https://cdn.ampproject.org/v0/amp-base-carousel-0.1.js – seems to be still suffering from this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants