Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amp-lightbox-gallery:1.0] Bento tracking issue #32759

Closed
10 tasks done
caroqliu opened this issue Feb 19, 2021 · 1 comment
Closed
10 tasks done

[amp-lightbox-gallery:1.0] Bento tracking issue #32759

caroqliu opened this issue Feb 19, 2021 · 1 comment
Projects

Comments

@caroqliu
Copy link
Contributor

caroqliu commented Feb 19, 2021

High-level requirements

Consideration Ready when Status
Component compatibility Conformance with 0.1 (see below)
Testing Unit tests and e2e tests from 0.1
Internationalization n/a n/a
Analytics Events
Accessibility Audit performed, 0.1 for reference
Page experience Audit performed
Documentation Written
Storybook Samples written

Component compatibility

Attributes to support: n/a
Features to support:

  • <img lightbox /> attribute
  • <amp-base-carousel lightbox /> attribute
  • <amp-stream-gallery lightbox /> attribute
  • captions

Migration Notes:

  • .amp-lightbox-gallery-caption is an exposed class for styling captions displayed in the Preact layer. In an HTML document (AMP or Bento mode) the exposed styling property is ::part(caption), due to the caption being provided across the shadow root.
  • lightbox-thumbnail-id is unsupported at this time until 0.1's expected behavior is resolved as a reference point for backwards compatibility.

Open tasks:

  • Initial implementation
  • Investigate doubly rendering same JSX Update: This behavior is avoidable via the render props
  • UI (grid view / carousel view / close button)
  • Gesture support
  • Modify history state (conformance to 0.1) - AMP only
  • Captions support ✨ amp-lightbox-gallery:1.0 Caption feature #35171
  • Grouping support
  • Analytics events
  • Video support with lightbox-thumbnail-id
  • Validation rules
@caroqliu
Copy link
Contributor Author

lightbox-thumbnail-id is mentioned in the component documentation without clear code samples or e2e tests on 0.1. When attempting to make a basic code sample, errors surface with Uncaught (in promise) TypeError: Cannot read property 'descriptionText' of undefined, for instance.

Given the above, 1.0 will not be supporting a lightbox-thumbnail-id in its first iteration, as it's not currently possible to discern what backward compatible behavior would be due to lack of functional examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Bento
  
Done
Development

No branches or pull requests

1 participant