You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
.amp-lightbox-gallery-caption is an exposed class for styling captions displayed in the Preact layer. In an HTML document (AMP or Bento mode) the exposed styling property is ::part(caption), due to the caption being provided across the shadow root.
lightbox-thumbnail-id is unsupported at this time until 0.1's expected behavior is resolved as a reference point for backwards compatibility.
Open tasks:
Initial implementation
Investigate doubly rendering same JSX Update: This behavior is avoidable via the render props
UI (grid view / carousel view / close button)
Gesture support
Modify history state (conformance to 0.1) - AMP only
lightbox-thumbnail-id is mentioned in the component documentation without clear code samples or e2e tests on 0.1. When attempting to make a basic code sample, errors surface with Uncaught (in promise) TypeError: Cannot read property 'descriptionText' of undefined, for instance.
Given the above, 1.0 will not be supporting a lightbox-thumbnail-id in its first iteration, as it's not currently possible to discern what backward compatible behavior would be due to lack of functional examples.
High-level requirements
Component compatibility
Attributes to support: n/a
Features to support:
<img lightbox />
attribute<amp-base-carousel lightbox />
attribute<amp-stream-gallery lightbox />
attributeMigration Notes:
.amp-lightbox-gallery-caption
is an exposed class for styling captions displayed in the Preact layer. In an HTML document (AMP or Bento mode) the exposed styling property is::part(caption)
, due to the caption being provided across the shadow root.lightbox-thumbnail-id
is unsupported at this time until 0.1's expected behavior is resolved as a reference point for backwards compatibility.Open tasks:
Investigate doubly rendering same JSXUpdate: This behavior is avoidable via therender
propsGesture supportVideo support withlightbox-thumbnail-id
The text was updated successfully, but these errors were encountered: