Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尭 Cherry-pick request for #32892 into #32874 (Pending) #32987

Closed
samouri opened this issue Mar 1, 2021 · 2 comments
Closed

馃尭 Cherry-pick request for #32892 into #32874 (Pending) #32987

samouri opened this issue Mar 1, 2021 · 2 comments
Labels
Cherry-pick: Beta Cherry-pick: Experimental Type: Release Used to track AMP releases from canary to production

Comments

@samouri
Copy link
Member

samouri commented Mar 1, 2021

Cherry-pick request

Issue PR Beta / Experimental? Stable? LTS? Release issue
ampproject/error-reporting#54 #32892 YES NO NO #32874

Why does this issue meet the cherry-pick criteria?

  • The issue creates a ton of noise in our error logs. Many many many spurious error reports per day. It is not user observable (unless they check network logs) and therefore not P0, so we should not attempt to patch stable. I believe it is still worth CPing the revert to Beta, in which it should have a few days to bake before being promoted to stable.
  • The diff is a revert and innocuous.

note: I am unsure if this is truly CP worthy, and am interested in second opinions! To see the impact, check the error dashboard which contains multiple separate errors with the same name "attempting to trigger analytics for detached target"

List the steps to manually verify the changes in this cherry-pick

  • I don't know how to reproduce. No verification needed beyond seeing the report remove from logs.

Mini-postmortem

TODO: This postmortem will be written after the cherry-pick deployment and before this issue is closed. Delete this TODO when the postmortem is ready.

Summary

<1-2 sentences summarizing the problem and root causes.>

Impact

  • <Which users were affected? Roughly how many?>
  • <How were users affected? E.g. partial or complete loss of functionality?>

Action Items

  • #<ISSUE_NUMBER>: <Add unit/integration/end-to-end test>
  • #<ISSUE_NUMBER>: <Add monitoring for edge case via error logging>
  • #<ISSUE_NUMBER>: <Refactor an easily misused API>

/cc @ampproject/release-on-duty @ampproject/wg-approvers @ampproject/cherry-pick-approvers

@kristoferbaxter
Copy link
Contributor

Since we already have several high priority cherrypicks happening right now, let's defer this logging output change to the next stable release.

@samouri
Copy link
Member Author

samouri commented Mar 1, 2021

It should be in the new Beta cut this week, so lets just close this and let it be fixed according to usual release schedule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cherry-pick: Beta Cherry-pick: Experimental Type: Release Used to track AMP releases from canary to production
Projects
None yet
Development

No branches or pull requests

3 participants