Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Page attachments][Outlink] Option to get domain favicon #34177

Open
processprocess opened this issue May 3, 2021 · 5 comments
Open

[Page attachments][Outlink] Option to get domain favicon #34177

processprocess opened this issue May 3, 2021 · 5 comments

Comments

@processprocess
Copy link
Contributor

A service can be used to fetch the outlink domain's favicon.
This could be a value for cta-image like cta-image="favicon"

If the domain does not have a favicon configured, this could fallback to the default link icon.

prototype
Replace the faviconURL param with any domain to preview the feature.

Concept approved by @hongcatlover

@ampproject/wg-stories

@newmuis
Copy link
Contributor

newmuis commented May 3, 2021

I think we should seriously consider making this the default, instead of an additional parameter.

/cc @hongcatlover @raovs @gmajoulet

@processprocess
Copy link
Contributor Author

I think we should seriously consider making this the default, instead of an additional parameter.

I'm leaning in that direction also.

  • It feels like it would align with expectations of what the image's function is.
  • It would give a story with multiple outlink buttons more variation by default without configuration.

@processprocess
Copy link
Contributor Author

I'm not sure how we could detect if we need to default to a fallback if we use this service though.
The request seems the same when it successfully gets a favicon and when it doesn't.

@mszylkowski
Copy link
Contributor

The size of the icon when it fails is independent of the variable, maybe it's possible to catch this? Check the document title also, it says (16x16) even if the ?sz=64

@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants