[Story interactive] Disable overlay on slider when dragging on mobile #35358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffolding_slider
…eractive_slider
…eractive_slider
…eractive_slider
…eractive_slider
|
Hey @gmajoulet, @mszylkowski! These files were changed: |
|
Since you have the contents of #35340 here, we can wait for that PR to merge before merging this one. LGTM for the actual change in this PR |
mszylkowski
changed the title
extensions/amp-story-interactive/0.1/amp-story-interactive-slider.js
Outdated
Show resolved
Hide resolved
mszylkowski
approved these changes
Jul 22, 2021
processprocess
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables the drag education while the user is interacting with the slider.
Demo: https://sydney-story-demo.web.app/examples/amp-story/interactive_slider.html
Closes #35260
Closes #35261